Sign upLogin

libertarian-party/partynest

View on GitHub
Star

Showing 3 of 11 total issues

Method nav_sidebar_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def nav_sidebar_item(scope_name, active_tab_name, tab_name, policy, url)
Severity: Minor
Found in app/helpers/navs_helper.rb - About 35 mins to fix

    Method nav_tabs_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def nav_tabs_item(scope_name, active_tab_name, tab_name, policy, url)
    Severity: Minor
    Found in app/helpers/navs_helper.rb - About 35 mins to fix

      Method create? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def create?
    return false if account.nil?

    return false unless account.person.nil?
    return false unless record.account.nil?
      Severity: Minor
      Found in app/policies/settings/person_policy.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language