librenms/librenms

View on GitHub
LibreNMS/OS/Openwrt.php

Summary

Maintainability
A
0 mins
Test Coverage

The method getSensorData has a boolean flag argument $stats, which is a certain sign of a Single Responsibility Principle violation.
Open

    private function getSensorData($type, $query = '', $system = false, $stats = false)
Severity: Minor
Found in LibreNMS/OS/Openwrt.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
      public function bar($flag = true) {
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

The method getSensorData has a boolean flag argument $system, which is a certain sign of a Single Responsibility Principle violation.
Open

    private function getSensorData($type, $query = '', $system = false, $stats = false)
Severity: Minor
Found in LibreNMS/OS/Openwrt.php by phpmd

Since: PHPMD 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example:

class Foo {
      public function bar($flag = true) {
      }
  }

Source: http://phpmd.org/rules/cleancode.txt

There are no issues that match your filters.

Category
Status