lifeart/ember-ast-hot-load

View on GitHub
addon/utils/cleaners.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function clearRequirejsCache has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function clearRequirejsCache(context, componentName) {
  const owner = getOwner(context);
  const config = owner.resolveRegistration('config:environment');

  const modulePrefix = get(config, 'modulePrefix') || 'dummy';
Severity: Minor
Found in addon/utils/cleaners.js - About 1 hr to fix

    Function clear has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function clear(context, owner, name, originalName) {
      if (context.get('templateCompilerKey')) {
        // Ember v3.2
        var templateCompiler = owner.lookup(context.get('templateCompilerKey'));
        var compileTimeLookup = templateCompiler.resolver;
    Severity: Minor
    Found in addon/utils/cleaners.js - About 1 hr to fix

      Function clear has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      function clear(context, owner, name, originalName) {
        if (context.get('templateCompilerKey')) {
          // Ember v3.2
          var templateCompiler = owner.lookup(context.get('templateCompilerKey'));
          var compileTimeLookup = templateCompiler.resolver;
      Severity: Minor
      Found in addon/utils/cleaners.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function clearRequirejsCache has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      export function clearRequirejsCache(context, componentName) {
        const owner = getOwner(context);
        const config = owner.resolveRegistration('config:environment');
      
        const modulePrefix = get(config, 'modulePrefix') || 'dummy';
      Severity: Minor
      Found in addon/utils/cleaners.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        if (context.get('templateCompilerKey')) {
          // Ember v3.2
          var templateCompiler = owner.lookup(context.get('templateCompilerKey'));
          var compileTimeLookup = templateCompiler.resolver;
          var compileRuntimeResolver = compileTimeLookup.resolver;
      Severity: Major
      Found in addon/utils/cleaners.js and 1 other location - About 1 hr to fix
      addon/utils/cleaners.js on lines 49..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        } else if (context.get('templateOptionsKey')) {
          // Ember v3.1.1
          var templateOptions = owner.lookup(context.get('templateOptionsKey'));
          var optionsTimeLookup = templateOptions.resolver;
          var optionsRuntimeResolver = optionsTimeLookup.resolver;
      Severity: Major
      Found in addon/utils/cleaners.js and 1 other location - About 1 hr to fix
      addon/utils/cleaners.js on lines 43..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 65.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status