lifeart/ember-ast-hot-load

View on GitHub
lib/hot-load-middleware.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function onFileRequested has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function onFileRequested(req, res) {
  var appFileName = req.params.name.split('---').join('/');
  if (!appFileName.endsWith('.js')) {
    return res.status(404).send('Not found');
  }
Severity: Major
Found in lib/hot-load-middleware.js - About 2 hrs to fix

    Function extractFileDataToResult has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function extractFileDataToResult(data, queryFile, queryComponents) {
      const definer = 'define(';
      const exports = data.split(definer);
      const originalFile = exports.join(definer);
      const components = queryComponents.split(',').filter((name) => name);
    Severity: Minor
    Found in lib/hot-load-middleware.js - About 1 hr to fix

      Function findEntypointFile has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function findEntypointFile(
        fileName,
        lookupFolder = ['dist', 'assets', ''].join(path.sep)
      ) {
        if (lookupFolder.charAt(lookupFolder.length - 1) !== path.sep) {
      Severity: Minor
      Found in lib/hot-load-middleware.js - About 1 hr to fix

        Function onFileRequested has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function onFileRequested(req, res) {
          var appFileName = req.params.name.split('---').join('/');
          if (!appFileName.endsWith('.js')) {
            return res.status(404).send('Not found');
          }
        Severity: Minor
        Found in lib/hot-load-middleware.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findEntypointFile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function findEntypointFile(
          fileName,
          lookupFolder = ['dist', 'assets', ''].join(path.sep)
        ) {
          if (lookupFolder.charAt(lookupFolder.length - 1) !== path.sep) {
        Severity: Minor
        Found in lib/hot-load-middleware.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status