Sign upLogin

linagora/hublin

View on GitHub
Star
backend/core/conference/index.js

Summary

Maintainability
D
1 day
Test Coverage

File index.js has 419 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';

const extend = require('extend');
const q = require('q');
const async = require('async');
Severity: Minor
Found in backend/core/conference/index.js - About 6 hrs to fix

    Function addHistory has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function addHistory(conference, user, status, callback) {
  if (!user) {
    return callback(new Error('Undefined user'));
  }
    Severity: Minor
    Found in backend/core/conference/index.js - About 1 hr to fix

      Function invite has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function invite(conference, creator, members, baseUrl, callback) {
  if (!conference) {
    return callback(new Error('Can not invite to an undefined conference'));
  }
      Severity: Minor
      Found in backend/core/conference/index.js - About 1 hr to fix

        Function addUser has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function addUser(conference, user, callback) {
  if (!user) {
    return callback(new Error('Undefined user'));
  }
        Severity: Minor
        Found in backend/core/conference/index.js - About 1 hr to fix

          Function sendInvitation has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function sendInvitation(conference, creator, member, baseUrl, callback) {
          Severity: Minor
          Found in backend/core/conference/index.js - About 35 mins to fix

            Function updateMemberField has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            function updateMemberField(conference, member, field, value, callback) {
            Severity: Minor
            Found in backend/core/conference/index.js - About 35 mins to fix

              Function invite has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              function invite(conference, creator, members, baseUrl, callback) {
              Severity: Minor
              Found in backend/core/conference/index.js - About 35 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  Conference.findOne({ _id: conference._id }, { members: { $elemMatch: { id: user.id, objectType: user.objectType } } }).exec(function(err, conf) {
    if (err) {
      return callback(err);
    }
    return callback(null, (conf && conf.members !== null && conf.members.length > 0));
                Severity: Major
                Found in backend/core/conference/index.js and 1 other location - About 1 hr to fix
                backend/core/conference/index.js on lines 120..132

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  Conference.findOne(
    { _id: conference._id },
    { members: { $elemMatch: { id: tuple.id, objectType: tuple.objectType } } }
  ).exec(function(err, conf) {
    if (err) {
                Severity: Major
                Found in backend/core/conference/index.js and 1 other location - About 1 hr to fix
                backend/core/conference/index.js on lines 332..337

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 56.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Parsing error: The keyword 'const' is reserved
                Open

                const extend = require('extend');
                Severity: Minor
                Found in backend/core/conference/index.js by eslint

                For more information visit Source: http://eslint.org/docs/rules/

                There are no issues that match your filters.

                Category
                Status