Showing 11 of 15 total issues
Method compareTo has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
Open
@Override
public int compareTo(IpRange other)
{
if (other == null) {
return 0;- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method lookup has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
Open
def lookup(ip)
return nil unless @db
ip = InetAddress.get_by_name(ip).address if ip.is_a?(String)
range = @db.find_range_for_ip(ip)
return nil unless range- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method compareTo has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
@Override
public int compareTo(IpRange other)
{
if (other == null) {
return 0;Avoid too many return statements within this method. Open
Open
return 0;Avoid too many return statements within this method. Open
Open
return -1;Avoid too many return statements within this method. Open
Open
return 1;Avoid too many return statements within this method. Open
Open
return 0;Avoid too many return statements within this method. Open
Open
return 0;Avoid too many return statements within this method. Open
Open
return -1;Avoid too many return statements within this method. Open
Open
return 1;Avoid too many return statements within this method. Open
Open
return 1;