Sign upLogin

liquidm/logging

View on GitHub
Star

Showing 4 of 4 total issues

Class ImprovedLogger has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

    class ImprovedLogger < ImprovedIO

      # Program name prefix. Used as ident for syslog backends.
      attr_accessor :progname
Severity: Minor
Found in lib/liquid/logging/improved_logger.rb - About 4 hrs to fix

    File improved_logger.rb has 314 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'logger'
require 'stringio'
require 'benchmark'

require 'liquid/logging/improved_io'
    Severity: Minor
    Found in lib/liquid/logging/improved_logger.rb - About 3 hrs to fix

      Method add has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def add(severity, message = nil, progname = nil, &block)
        severity ||= UNKNOWN
        if severity < @level
          return true
        end
      Severity: Minor
      Found in lib/liquid/logging/document_logger.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method puts has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def puts(*arguments)
        return nil if arguments.empty?

        arguments.each do |arg|
          if arg.is_a?(Array)
      Severity: Minor
      Found in lib/liquid/logging/improved_io.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language