locomotivecms/steam

View on GitHub

Showing 12 of 89 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                  options << case key.to_sym
                  when :quality
                    "-quality #{value}"
                  when :optimize # Shortcut helper to set quality, progressive and strip
                    "-quality #{value} -strip -interlace Plane"
Severity: Minor
Found in lib/locomotive/steam/liquid/tags/editable/file.rb and 1 other location - About 45 mins to fix
lib/locomotive/steam/liquid/filters/resize.rb on lines 20..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                options << case k.to_sym
                when :quality
                  "-quality #{v}"
                when :optimize # Shortcut helper to set quality, progressive and strip
                  "-quality #{v} -strip -interlace Plane"
Severity: Minor
Found in lib/locomotive/steam/liquid/filters/resize.rb and 1 other location - About 45 mins to fix
lib/locomotive/steam/liquid/tags/editable/file.rb on lines 61..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def reset_password(options)
        return if authenticated?

        status, entry = services.auth.reset_password(options, request)

Severity: Minor
Found in lib/locomotive/steam/middlewares/auth.rb and 1 other location - About 25 mins to fix
lib/locomotive/steam/middlewares/auth.rb on lines 52..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      def sign_in(options)
        return if authenticated?

        status, entry = services.auth.sign_in(options, request)

Severity: Minor
Found in lib/locomotive/steam/middlewares/auth.rb and 1 other location - About 25 mins to fix
lib/locomotive/steam/middlewares/auth.rb on lines 85..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 29.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def end_of_year(input)
            return '' if input.blank?

            if input.respond_to? :end_of_year
              return input.end_of_year
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 81..90
lib/locomotive/steam/liquid/filters/date.rb on lines 93..102
lib/locomotive/steam/liquid/filters/date.rb on lines 105..114
lib/locomotive/steam/liquid/filters/date.rb on lines 117..126
lib/locomotive/steam/liquid/filters/date.rb on lines 129..138
lib/locomotive/steam/liquid/filters/date.rb on lines 141..150
lib/locomotive/steam/liquid/filters/date.rb on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def end_of_week(input)
            return '' if input.blank?

            if input.respond_to? :end_of_week
              return input.end_of_week
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 69..78
lib/locomotive/steam/liquid/filters/date.rb on lines 81..90
lib/locomotive/steam/liquid/filters/date.rb on lines 93..102
lib/locomotive/steam/liquid/filters/date.rb on lines 105..114
lib/locomotive/steam/liquid/filters/date.rb on lines 129..138
lib/locomotive/steam/liquid/filters/date.rb on lines 141..150
lib/locomotive/steam/liquid/filters/date.rb on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def end_of_day(input)
            return '' if input.blank?

            if input.respond_to? :end_of_day
              return input.end_of_day
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 69..78
lib/locomotive/steam/liquid/filters/date.rb on lines 81..90
lib/locomotive/steam/liquid/filters/date.rb on lines 93..102
lib/locomotive/steam/liquid/filters/date.rb on lines 105..114
lib/locomotive/steam/liquid/filters/date.rb on lines 117..126
lib/locomotive/steam/liquid/filters/date.rb on lines 129..138
lib/locomotive/steam/liquid/filters/date.rb on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def beginning_of_month(input)
            return '' if input.blank?

            if input.respond_to? :beginning_of_month
              return input.beginning_of_month
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 69..78
lib/locomotive/steam/liquid/filters/date.rb on lines 81..90
lib/locomotive/steam/liquid/filters/date.rb on lines 93..102
lib/locomotive/steam/liquid/filters/date.rb on lines 117..126
lib/locomotive/steam/liquid/filters/date.rb on lines 129..138
lib/locomotive/steam/liquid/filters/date.rb on lines 141..150
lib/locomotive/steam/liquid/filters/date.rb on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def beginning_of_week(input)
            return '' if input.blank?

            if input.respond_to? :beginning_of_week
              return input.beginning_of_week
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 69..78
lib/locomotive/steam/liquid/filters/date.rb on lines 81..90
lib/locomotive/steam/liquid/filters/date.rb on lines 93..102
lib/locomotive/steam/liquid/filters/date.rb on lines 105..114
lib/locomotive/steam/liquid/filters/date.rb on lines 117..126
lib/locomotive/steam/liquid/filters/date.rb on lines 141..150
lib/locomotive/steam/liquid/filters/date.rb on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def beginning_of_day(input)
            return '' if input.blank?

            if input.respond_to? :beginning_of_day
              return input.beginning_of_day
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 69..78
lib/locomotive/steam/liquid/filters/date.rb on lines 81..90
lib/locomotive/steam/liquid/filters/date.rb on lines 93..102
lib/locomotive/steam/liquid/filters/date.rb on lines 105..114
lib/locomotive/steam/liquid/filters/date.rb on lines 117..126
lib/locomotive/steam/liquid/filters/date.rb on lines 129..138
lib/locomotive/steam/liquid/filters/date.rb on lines 141..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def beginning_of_year(input)
            return '' if input.blank?

            if input.respond_to? :beginning_of_year
              return input.beginning_of_year
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 69..78
lib/locomotive/steam/liquid/filters/date.rb on lines 93..102
lib/locomotive/steam/liquid/filters/date.rb on lines 105..114
lib/locomotive/steam/liquid/filters/date.rb on lines 117..126
lib/locomotive/steam/liquid/filters/date.rb on lines 129..138
lib/locomotive/steam/liquid/filters/date.rb on lines 141..150
lib/locomotive/steam/liquid/filters/date.rb on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

          def end_of_month(input)
            return '' if input.blank?

            if input.respond_to? :end_of_month
              return input.end_of_month
Severity: Major
Found in lib/locomotive/steam/liquid/filters/date.rb and 7 other locations - About 20 mins to fix
lib/locomotive/steam/liquid/filters/date.rb on lines 69..78
lib/locomotive/steam/liquid/filters/date.rb on lines 81..90
lib/locomotive/steam/liquid/filters/date.rb on lines 105..114
lib/locomotive/steam/liquid/filters/date.rb on lines 117..126
lib/locomotive/steam/liquid/filters/date.rb on lines 129..138
lib/locomotive/steam/liquid/filters/date.rb on lines 141..150
lib/locomotive/steam/liquid/filters/date.rb on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language