Sign upLogin

longitude-one/wkt-parser

View on GitHub
Star

Showing 5 of 7 total issues

File Parser.php has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the LongitudeOne WKT-Parser project.
 *
Severity: Minor
Found in lib/LongitudeOne/Geo/WKT/Parser.php - About 2 hrs to fix

    Method geometry has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function geometry(): array
    {
        try {
            $type = $this->type();
        } catch (UnexpectedValueException $e) {
    Severity: Minor
    Found in lib/LongitudeOne/Geo/WKT/Parser.php - About 1 hr to fix

      Function getType has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getType(&$value): int
    {
        if (is_numeric($value)) {
            $value += 0;
      Severity: Minor
      Found in lib/LongitudeOne/Geo/WKT/Lexer.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function point has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function point(): array
    {
        if (null !== $this->dimension) {
            return $this->coordinates(2 + strlen($this->dimension));
        }
      Severity: Minor
      Found in lib/LongitudeOne/Geo/WKT/Parser.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return match ($value) {
            ',' => self::T_COMMA,
            '(' => self::T_OPEN_PARENTHESIS,
            ')' => self::T_CLOSE_PARENTHESIS,
            '=' => self::T_EQUALS,
      Severity: Major
      Found in lib/LongitudeOne/Geo/WKT/Lexer.php - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language