loomio/loomio

View on GitHub

Showing 260 of 472 total issues

Method audience_users has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def self.audience_users(model, kind, actor, exclude_members = false, include_actor = false)
    users = case kind
    when /group-\d+/
      id = kind.match(/group-(\d+)/)[1].to_i
      group = model.group.parent_or_self.self_and_subgroups.find(id)
Severity: Minor
Found in app/services/announcement_service.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method send_single_mail has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def send_single_mail(locale: , to:, subject_key:, subject_params: {}, subject_prefix: '', subject_is_title: false, **options)
    return if NoSpam::SPAM_REGEX.match?(to)
    return if NOTIFICATIONS_EMAIL_ADDRESS == to

    I18n.with_locale(first_supported_locale(locale)) do
Severity: Minor
Found in app/mailers/base_mailer.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method perform has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def perform(class_name, method_name, arg1 = nil, arg2 = nil, arg3 = nil, arg4 = nil, arg5 = nil)
Severity: Major
Found in app/workers/generic_worker.rb - About 50 mins to fix

    Method initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(user)
        super(user)
    
        can [:create], ::Comment do |comment|
          comment.discussion &&
    Severity: Minor
    Found in app/models/ability/comment.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function belongsTo has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      belongsTo(name, userArgs) {
        const values = {
          from: name + 's',
          by: name + 'Id'
        };
    Severity: Minor
    Found in vue/src/shared/record_store/base_model.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function attributeIsModified has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      attributeIsModified(attributeName) {
        const strip = function(val) {
          const doc = new DOMParser().parseFromString(val, 'text/html');
          const o = (doc.body.textContent || "").trim();
          if (['null', 'undefined'].includes(o)) {
    Severity: Minor
    Found in vue/src/shared/record_store/base_model.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

              if (current_word) {
                words.push(current_word);
              }
    Severity: Major
    Found in vue/src/shared/helpers/html_diff.js - About 45 mins to fix

      Function approximate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export var approximate = function(date, zone, dateTimePref) {
        if (zone == null) { zone = AppConfig.timeZone; }
        if (dateTimePref == null) { ({
          dateTimePref
        } = Session.user()); }
      Severity: Minor
      Found in vue/src/shared/helpers/format_time.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function groupPrivacyStatement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export var groupPrivacyStatement = function(group) {
        if (group.parentId && group.parent().privacyIsSecret()) {
          if (group.privacyIsClosed()) {
            return 'group_form.privacy_statement.private_to_parent_members';
          } else {
      Severity: Minor
      Found in vue/src/shared/helpers/helptext.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method pg_search_insert_statement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.pg_search_insert_statement(id: nil, author_id: nil, discussion_id: nil, poll_id: nil)
          content_str = "regexp_replace(CONCAT_WS(' ', stances.reason, users.name), E'<[^>]+>', '', 'gi')"
          <<~SQL.squish
            INSERT INTO pg_search_documents (
              searchable_type,
      Severity: Minor
      Found in app/models/stance.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method pg_search_insert_statement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.pg_search_insert_statement(id: nil, author_id: nil, discussion_id: nil, poll_id: nil)
          content_str = "regexp_replace(CONCAT_WS(' ', outcomes.statement, users.name), E'<[^>]+>', '', 'gi')"
          <<~SQL.squish
            INSERT INTO pg_search_documents (
              searchable_type,
      Severity: Minor
      Found in app/models/outcome.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method pg_search_insert_statement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.pg_search_insert_statement(id: nil, author_id: nil, discussion_id: nil)
          content_str = "regexp_replace(CONCAT_WS(' ', comments.body, users.name), E'<[^>]+>', '', 'gi')"
          <<~SQL.squish
            INSERT INTO pg_search_documents (
              searchable_type,
      Severity: Minor
      Found in app/models/comment.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

              } else if (/[\w\#@]+/i.test(char)) {
                current_word += char;
              } else {
                if (current_word) {
                  words.push(current_word);
      Severity: Major
      Found in vue/src/shared/helpers/html_diff.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if (current_word) {
                    words.push(current_word);
                  }
        Severity: Major
        Found in vue/src/shared/helpers/html_diff.js - About 45 mins to fix

          Method commit! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def commit!
              @changed.each do |attribute|
                case attribute
                when 'is_visible_to_public'
                  if group.is_hidden_from_public?
          Severity: Minor
          Found in app/services/group_service/privacy_change.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method update_model has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.update_model(model, tasks_data)
              uids = tasks_data.map {|t| t[:uid] }
              existing_uids = model.tasks.pluck(:uid)
              new_uids = uids - existing_uids
              removed_uids = existing_uids - uids
          Severity: Minor
          Found in app/services/task_service.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method redirect_to has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def redirect_to(url, opts = {})
              return super unless url.is_a? String # GK: for now this override only covers cases where a string has been passed in, so it does not cover cases of a Hash or a Record being passed in
              host = URI(url).host
              if ENV['USE_VUE'] && Rails.env.development? && host == "localhost"
                path = URI(url).path
          Severity: Minor
          Found in app/controllers/application_controller.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
              @email_can_be_verified = email_can_be_verified?
              self.resource = UserService.create(params: sign_up_params)
              if !resource.errors.any?
                save_detected_locale(resource)
          Severity: Minor
          Found in app/controllers/api/v1/registrations_controller.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def create
              email = params[:user_email].strip
          
              user = User.verified.find_by(email: email)
              if !user
          Severity: Minor
          Found in app/controllers/api/v1/trials_controller.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method bug_tunnel has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def bug_tunnel
              raise "no sentry dsn" unless ENV['SENTRY_PUBLIC_DSN']
          
              uri = URI(ENV['SENTRY_PUBLIC_DSN'])
              known_host = uri.host
          Severity: Minor
          Found in app/controllers/application_controller.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language