loomio/loomio

View on GitHub
vue/src/shared/helpers/html_diff.js

Summary

Maintainability
C
1 day
Test Coverage

File html_diff.js has 331 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var Match, calculate_operations, consecutive_where, create_index, diff, find_match, find_matching_blocks, html_to_tokens, is_end_of_tag, is_start_of_tag, is_tag, is_whitespace, isnt_tag, op_map, recursively_find_matching_blocks, render_operations, wrap;

is_end_of_tag = function(char) {
  return char === '>';
};
Severity: Minor
Found in vue/src/shared/helpers/html_diff.js - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

              if (current_word) {
                words.push(current_word);
              }
    Severity: Major
    Found in vue/src/shared/helpers/html_diff.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

              } else if (/[\w\#@]+/i.test(char)) {
                current_word += char;
              } else {
                if (current_word) {
                  words.push(current_word);
      Severity: Major
      Found in vue/src/shared/helpers/html_diff.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                  if (current_word) {
                    words.push(current_word);
                  }
        Severity: Major
        Found in vue/src/shared/helpers/html_diff.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            insert: function(op, before_tokens, after_tokens) {
              var val;
              val = after_tokens.slice(op.start_in_after, +op.end_in_after + 1 || 9e9);
              return wrap('ins', val);
            },
          Severity: Major
          Found in vue/src/shared/helpers/html_diff.js and 1 other location - About 1 hr to fix
          vue/src/shared/helpers/html_diff.js on lines 314..318

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            "delete": function(op, before_tokens, after_tokens) {
              var val;
              val = before_tokens.slice(op.start_in_before, +op.end_in_before + 1 || 9e9);
              return wrap('del', val);
            }
          Severity: Major
          Found in vue/src/shared/helpers/html_diff.js and 1 other location - About 1 hr to fix
          vue/src/shared/helpers/html_diff.js on lines 309..313

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status