Sign upLogin

loomio/loomio

View on GitHub
Star
vue/src/shared/models/poll_model.js

Summary

Maintainability
D
3 days
Test Coverage

PollModel has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class PollModel extends BaseModel {
  static singular = 'poll';
  static plural = 'polls';
  static uniqueIndices = ['id', 'key'];
  static indices = ['discussionId', 'authorId', 'groupId'];
Severity: Major
Found in vue/src/shared/models/poll_model.js - About 7 hrs to fix

    File poll_model.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import BaseModel        from '@/shared/record_store/base_model';
import AppConfig        from '@/shared/services/app_config';
import Session          from '@/shared/services/session';
import HasDocuments     from '@/shared/mixins/has_documents';
import HasTranslations  from '@/shared/mixins/has_translations';
    Severity: Minor
    Found in vue/src/shared/models/poll_model.js - About 4 hrs to fix

      Function defaultValues has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        defaultValues() {
    return {
      discussionId: null,
      title: '',
      titlePlaceholder: null,
      Severity: Minor
      Found in vue/src/shared/models/poll_model.js - About 1 hr to fix

        Function pieSlices has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          pieSlices() {
    let slices = [];
    if ((this.pollType === 'count') && this.results.find(r => r.icon === 'agree')) {
      const agree = this.results.find(r => r.icon === 'agree');
      if (agree.score < this.agreeTarget) {
        Severity: Minor
        Found in vue/src/shared/models/poll_model.js - About 1 hr to fix

          Function adminsInclude has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            adminsInclude(user) {
    const stance = this.stanceFor(user);
    return ((this.authorId === user.id) && !this.groupId) ||
    ((this.authorId === user.id) && (this.groupId && this.group().membersInclude(user))) ||
    ((this.authorId === user.id) && (this.discussionId && this.discussion().membersInclude(user))) ||
          Severity: Minor
          Found in vue/src/shared/models/poll_model.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function clonePoll has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            clonePoll() {
    const clone = this.clone();
    clone.id = null;
    clone.key = null;
    clone.sourceTemplateId = this.id;
          Severity: Minor
          Found in vue/src/shared/models/poll_model.js - About 1 hr to fix

            Function pieSlices has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              pieSlices() {
    let slices = [];
    if ((this.pollType === 'count') && this.results.find(r => r.icon === 'agree')) {
      const agree = this.results.find(r => r.icon === 'agree');
      if (agree.score < this.agreeTarget) {
            Severity: Minor
            Found in vue/src/shared/models/poll_model.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              constructor(...args) {
    super(...args);
    this.close = this.close.bind(this);
    this.reopen = this.reopen.bind(this);
    this.addToThread = this.addToThread.bind(this);
            Severity: Major
            Found in vue/src/shared/models/poll_model.js and 1 other location - About 5 hrs to fix
            vue/src/shared/models/group_model.js on lines 13..20

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 135.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              bestNamedId() {
    return ((this.id && this) || (this.discusionId && this.discussion()) || (this.groupId && this.group()) || {namedId() {}}).namedId();
  }
            Severity: Major
            Found in vue/src/shared/models/poll_model.js and 1 other location - About 2 hrs to fix
            vue/src/shared/models/outcome_model.js on lines 94..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 77.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status