Sign upLogin

lowdefy/lowdefy

View on GitHub
Star
packages/engine/src/Blocks.js

Summary

Maintainability
F
3 days
Test Coverage

File Blocks.js has 555 lines of code (exceeds 250 allowed). Consider refactoring.
Confirmed

/* eslint-disable no-param-reassign */

/*
  Copyright 2020-2024 Lowdefy, Inc
Severity: Major
Found in packages/engine/src/Blocks.js - About 1 day to fix

    Function init has 144 lines of code (exceeds 25 allowed). Consider refactoring.
    Confirmed

      init(initState) {
    this.loopBlocks((block) => {
      block.idPattern = block.id;
      block.blockIdPattern = block.blockId;
      block.id = applyArrayIndices(this.arrayIndices, block.idPattern);
    Severity: Major
    Found in packages/engine/src/Blocks.js - About 5 hrs to fix

      Function recEval has 123 lines of code (exceeds 25 allowed). Consider refactoring.
      Confirmed

        recEval(visibleParent) {
    let repeat = false;
    this.loopBlocks((block) => {
      if (block.meta.category === 'input') {
        const stateValue = get(this.context.state, block.blockId);
      Severity: Major
      Found in packages/engine/src/Blocks.js - About 4 hrs to fix

        Function reset has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Confirmed

          reset(initWithState) {
    const initState = serializer.copy(initWithState || this.context.state);
    this.loopBlocks((block) => {
      block.update = true;
      block.showValidation = false;
        Severity: Minor
        Found in packages/engine/src/Blocks.js - About 1 hr to fix

          Function updateState has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Confirmed

            updateState() {
    const toSet = new Set();
    const toDelete = new Set();
    this.loopBlocks((block) => {
      if (block.visibleEval.output !== false) {
          Severity: Minor
          Found in packages/engine/src/Blocks.js - About 1 hr to fix

            Function setBlocksCache has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Confirmed

              setBlocksCache() {
    this.loopBlocks((block) => {
      if (block.update) {
        block.update = false;
        block.eval = {
            Severity: Minor
            Found in packages/engine/src/Blocks.js - About 1 hr to fix

              Function constructor has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Confirmed

                constructor({ arrayIndices = [], areas, context }) {
    this.id = Math.random()
      .toString(36)
      .replace(/[^a-z]+/g, '')
      .substring(0, 5);
              Severity: Minor
              Found in packages/engine/src/Blocks.js - About 1 hr to fix

                TODO found
                Open

                        // TODO: to initialize new object in array, the new value should be passed by method to unshiftItem and pushItem
                Severity: Minor
                Found in packages/engine/src/Blocks.js by fixme

                TODO found
                Open

                        // TODO: related to #345
                Severity: Minor
                Found in packages/engine/src/Blocks.js by fixme

                Identical blocks of code found in 2 locations. Consider refactoring.
                Invalid

                      if (block.meta.category === 'container') {
        this.subBlocks[block.id].forEach((blockClass) => {
          blockClass.recContainerDelState(toDelete);
        });
      } else {
                Severity: Major
                Found in packages/engine/src/Blocks.js and 1 other location - About 2 hrs to fix
                packages/engine/src/Blocks.js on lines 458..464

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 78.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Invalid

                      } else if (block.meta.category === 'container') {
        this.subBlocks[block.id].forEach((blockClass) => {
          blockClass.recContainerDelState(toDelete);
        });
      } else {
                Severity: Major
                Found in packages/engine/src/Blocks.js and 1 other location - About 2 hrs to fix
                packages/engine/src/Blocks.js on lines 475..481

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 78.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status