Sign upLogin

lpaulger/cribbage-the-game

View on GitHub
Star
app/scripts/gameStates/BaseState.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function bindEvents has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  BaseState.prototype.bindEvents = function(){
    $('#deck').on('click', function(e){
      this.unbindEvents();
      var cardIndex = $('#deck ul').children().indexOf(e.target.parentNode);
      $(e.target).addClass('selected');
Severity: Minor
Found in app/scripts/gameStates/BaseState.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

          return 0;
    Severity: Major
    Found in app/scripts/gameStates/BaseState.js - About 30 mins to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          $(document).off('backbutton').on('backbutton', function(){
      this.mediator.publish('transition', 'Home');
    }.bind(this));
      Severity: Major
      Found in app/scripts/gameStates/BaseState.js and 2 other locations - About 55 mins to fix
      app/scripts/gameStates/HomeState.js on lines 32..34
      app/scripts/gameStates/InfoState.js on lines 23..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          $('a.home-link').on('click', function(){
      this.mediator.publish('transition', 'Home');
    }.bind(this));
      Severity: Major
      Found in app/scripts/gameStates/BaseState.js and 5 other locations - About 30 mins to fix
      app/scripts/gameStates/BaseState.js on lines 127..129
      app/scripts/gameStates/HomeState.js on lines 28..30
      app/scripts/gameStates/InfoState.js on lines 19..21
      app/scripts/gameStates/SettingsState.js on lines 27..29
      app/scripts/gameStates/SummaryState.js on lines 22..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          $('a.help-link').on('click', function(){
      this.mediator.publish('transition', 'Info');
    }.bind(this));
      Severity: Major
      Found in app/scripts/gameStates/BaseState.js and 5 other locations - About 30 mins to fix
      app/scripts/gameStates/BaseState.js on lines 123..125
      app/scripts/gameStates/HomeState.js on lines 28..30
      app/scripts/gameStates/InfoState.js on lines 19..21
      app/scripts/gameStates/SettingsState.js on lines 27..29
      app/scripts/gameStates/SummaryState.js on lines 22..24

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status