lsm/micromono

View on GitHub
lib/service/local.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function generateAnnouncement has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.generateAnnouncement = function(service, serviceInfo, host, web, api, channel) {
  var ann = new Announcement(service)
  ann.host = host
  if (web.asset)
    ann.asset = web.asset
Severity: Minor
Found in lib/service/local.js - About 1 hr to fix

    Function generateAnnouncement has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.generateAnnouncement = function(service, serviceInfo, host, web, api, channel) {
      var ann = new Announcement(service)
      ann.host = host
      if (web.asset)
        ann.asset = web.asset
    Severity: Minor
    Found in lib/service/local.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function generateAnnouncement has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    exports.generateAnnouncement = function(service, serviceInfo, host, web, api, channel) {
    Severity: Minor
    Found in lib/service/local.js - About 45 mins to fix

      Consider simplifying this complex logical expression.
      Open

        if (web.use || web.route || web.middleware || web.asset) {
          var framework = web.framework
          web.framework = framework && framework.type || framework
          web.upgradeUrl = service.upgradeUrl
          delete web.asset
      Severity: Major
      Found in lib/service/local.js - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status