Sign upLogin

lsm/micromono

View on GitHub
Star
lib/web/asset/pjson.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function getCommonBundles has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.getCommonBundles = function(assetInfo, servicesWithAsset, assetDependenciesMap) {
  var numServices = servicesWithAsset.length
  // Any dependency required by 70% or more of the services
  // Minus any dependencies in assetInfo.micromono.bundleDeps
  // (which will be bundled with the main bundle.)
Severity: Minor
Found in lib/web/asset/pjson.js - About 1 hr to fix

    Function getAssetInfo has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.getAssetInfo = function(packagePath, packageJSON, serviceName) {
  serviceName = serviceName || ''

  var assetInfo
  var publicURL
    Severity: Minor
    Found in lib/web/asset/pjson.js - About 1 hr to fix

      Function mergeAssetDependencies has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.mergeAssetDependencies = function(dstAssetInfo, srcAssetInfo) {
  var assetDependenciesChanged = undefined

  if (srcAssetInfo.dependencies) {
    var srcDeps = srcAssetInfo.dependencies
      Severity: Minor
      Found in lib/web/asset/pjson.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

          if (packageJSON.jspm) {
    assetInfo = assign({}, packageJSON.jspm)
    assetInfo.name = serviceName
    var directories = assetInfo.directories = assetInfo.directories || {}
        Severity: Major
        Found in lib/web/asset/pjson.js - About 40 mins to fix

          Function getAssetInfo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.getAssetInfo = function(packagePath, packageJSON, serviceName) {
  serviceName = serviceName || ''

  var assetInfo
  var publicURL
          Severity: Minor
          Found in lib/web/asset/pjson.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status