Showing 36 of 55 total issues
File province.rb
has 1120 lines of code (exceeds 250 allowed). Consider refactoring. Open
module Adapi
class ConstantData::Location < ConstantData
class Province
PROVINCES = [
Method create
has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring. Open
def create(operator = 'ADD')
# step 1 - convert input hash to new array of criteria
# example: :language => [ :en, :cs ] -> [ [:language, :en], [:language, :cs] ]
criteria_array = []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find
has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring. Open
def self.find(amount = :all, params = {})
# set amount = :first by default
if amount.is_a?(Hash) and params.empty?
params = amount.clone
amount = :first
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method mutate
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
def mutate(operation)
operation = [operation] unless operation.is_a?(Array)
# fix to save space during specifyng operations
operation = operation.map do |op|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_ad_groups!
has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open
def update_ad_groups!(ad_groups = [])
return true if ad_groups.nil? or ad_groups.empty?
# FIXME deep symbolize_keys
ad_groups.map! { |ag| ag.symbolize_keys }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create
has 57 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create(operator = 'ADD')
# step 1 - convert input hash to new array of criteria
# example: :language => [ :en, :cs ] -> [ [:language, :en], [:language, :cs] ]
criteria_array = []
Method create
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def create
return false unless self.valid?
# set defaults for budget for campaign.create only
self.budget = budget.reverse_merge( period: 'DAILY', delivery_method: 'STANDARD' )
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.find(amount = :all, params = {})
# set amount = :first by default
if amount.is_a?(Hash) and params.empty?
params = amount.clone
amount = :first
Method update
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update(params = {})
# step 1. update core attributes
core_attributes = [ :id, :campaign_id, :name, :status, :bids ]
# get operand in google format
# parse the given params by initialize method...
Method create_criterion
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.create_criterion(criterion_type, criterion_data)
case criterion_type
#
# example: [:language, 'en'] -> {:xsi_type => 'Language', :id => 1000}
when :language
Method update
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def update(params = {})
# step 1. update core attributes
core_attributes = [ :id, :campaign_id, :name, :status, :bids ]
# get operand in google format
# parse the given params by initialize method...
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def self.find(params = {})
params.symbolize_keys!
if params[:conditions]
params[:campaign_id] = params[:campaign_id] || params[:conditions][:campaign_id]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def create
return false unless self.valid?
operand = Hash[
[:campaign_id, :name, :status, :bids].map do |k|
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def self.find(amount = :all, params = {})
# find single campaign by id
if params.empty? and not amount.is_a?(Symbol)
params[:id] = amount.to_i
amount = :first
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.find(amount = :all, params = {})
params[:format] ||= :google # default, don't do anything with the data from google
params.symbolize_keys!
# this has no effect, it's here just to have the same interface everywhere
Method create
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
def create
return false unless self.valid?
# set defaults for budget for campaign.create only
self.budget = budget.reverse_merge( period: 'DAILY', delivery_method: 'STANDARD' )
Method update_ad_groups!
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def update_ad_groups!(ad_groups = [])
return true if ad_groups.nil? or ad_groups.empty?
# FIXME deep symbolize_keys
ad_groups.map! { |ag| ag.symbolize_keys }
Method load_settings
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def self.load_settings(params = {})
if params[:in_hash]
return @settings = params[:in_hash]
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def initialize(params = {})
params.symbolize_keys!
raise "Missing Service Name" unless params[:service_name]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def self.find(amount = :all, params = {})
params.symbolize_keys!
first_only = (amount.to_sym == :first)
# by default, exclude ad_groups with status DELETED
params[:status] ||= %w{ ENABLED PAUSED }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"