Sign upLogin

luxflux/cloudbalancer

View on GitHub
Star

Showing 7 of 7 total issues

Method update_heartbeat has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def update_heartbeat(payload)
      payload[:services].each do |service|
        if my_service = @services.find_name(service.to_sym)
          if node = my_service.nodes.find_name(payload[:node])
            node.last_heartbeat = Time.now
Severity: Minor
Found in lib/cloud_balancer/load_balancer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle_message has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def handle_message(metadata, payload)

      puts metadata.inspect
      begin
        if metadata[:topic]
Severity: Minor
Found in lib/cloud_balancer/load_balancer.rb - About 1 hr to fix

    Method register_node has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def register_node(service, port, node, password)
      service = service.to_sym
      port = port.to_i

      if password == @config.cluster_password
    Severity: Minor
    Found in lib/cloud_balancer/load_balancer.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method heartbeat_check has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def heartbeat_check
      @services.each do |service|
        service.nodes.each do |node|
          if node.last_heartbeat.nil? or node.last_heartbeat < Time.now - 3.seconds
            unless node.offline?
    Severity: Minor
    Found in lib/cloud_balancer/load_balancer.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method algorithm has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def algorithm
      @backend = (@backend + 1) % @backends.length

      if @backend == 0
        @current_weight = @current_weight - @backends.gcd
    Severity: Minor
    Found in lib/cloud_balancer/load_balancer/algorithms/wrr.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(name, ip, port, algorithm = nil, nodes = ServiceNodes.new, algo_options = nil)
    Severity: Minor
    Found in lib/cloud_balancer/load_balancer/service.rb - About 45 mins to fix

      Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def initialize(name, port, weight = 10, last_heartbeat = Time.now, online = false)
      Severity: Minor
      Found in lib/cloud_balancer/load_balancer/service_node.rb - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language