Sign upLogin

lyfeyaj/poplar

View on GitHub
Star
lib/adapters/rest.js

Summary

Maintainability
D
1 day
Test Coverage

Function errorHandler has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

RestAdapter.errorHandler = function(options) {
  options = options || {};
  return function restErrorHandler(err, req, res, next) {
    if (typeof options.errorHandler === 'function') {
      try {
Severity: Minor
Found in lib/adapters/rest.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createHandler has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

RestAdapter.prototype.createHandler =  function() {
  var router = express.Router(this.options);
  var adapter = this;
  var methods = this.api.allMethods();
Severity: Major
Found in lib/adapters/rest.js - About 2 hrs to fix

    Function errorHandler has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    RestAdapter.errorHandler = function(options) {
  options = options || {};
  return function restErrorHandler(err, req, res, next) {
    if (typeof options.errorHandler === 'function') {
      try {
    Severity: Minor
    Found in lib/adapters/rest.js - About 1 hr to fix

      Function restErrorHandler has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        return function restErrorHandler(err, req, res, next) {
    if (typeof options.errorHandler === 'function') {
      try {
        options.errorHandler(err, req, res, next);
      } catch (e) {
      Severity: Minor
      Found in lib/adapters/rest.js - About 1 hr to fix

        Function createHandler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        RestAdapter.prototype.createHandler =  function() {
  var router = express.Router(this.options);
  var adapter = this;
  var methods = this.api.allMethods();
        Severity: Minor
        Found in lib/adapters/rest.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        RestAdapter.urlNotFoundHandler = function() {
  return function restUrlNotFound(req, res, next) {
    var message = 'There is no method to handle ' + req.method + ' ' + req.url;
    var error = new Error(message);
    error.status = error.statusCode = 404;
        Severity: Major
        Found in lib/adapters/rest.js and 1 other location - About 3 hrs to fix
        lib/adapters/rest.js on lines 194..201

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        RestAdapter.methodNotFoundHandler = function() {
  return function restMethodNotFound(req, res, next) {
    var message ='There is no method handling ' + req.method + ' ' + req.url;
    var error = new Error(message);
    error.status = error.statusCode = 404;
        Severity: Major
        Found in lib/adapters/rest.js and 1 other location - About 3 hrs to fix
        lib/adapters/rest.js on lines 206..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 97.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status