Sign upLogin

lyfeyaj/poplar

View on GitHub
Star
lib/contexts/http.js

Summary

Maintainability
F
5 days
Test Coverage

Function buildArgs has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

HttpContext.prototype.buildArgs = function(method) {
  var args = {};
  var ctx = this;
  var accepts = method.accepts;
Severity: Minor
Found in lib/contexts/http.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File http.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Expose `HttpContext`.
 */
module.exports = HttpContext;
Severity: Minor
Found in lib/contexts/http.js - About 4 hrs to fix

    Function buildArgs has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    HttpContext.prototype.buildArgs = function(method) {
  var args = {};
  var ctx = this;
  var accepts = method.accepts;
    Severity: Major
    Found in lib/contexts/http.js - About 3 hrs to fix

      Function done has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

      HttpContext.prototype.done = function() {
  // if response is already returned, then do nothing
  if (this._done) return;
      Severity: Minor
      Found in lib/contexts/http.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getArgByName has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

      HttpContext.prototype.getArgByName = function(name, options) {
  var req = this.req;
  var args = req.params && req.params.args !== undefined ? req.params.args :
             req.body && req.body.args !== undefined ? req.body.args :
             req.query && req.query.args !== undefined ? req.query.args :
      Severity: Minor
      Found in lib/contexts/http.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function applyDelegates has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      HttpContext.prototype.applyDelegates = function(method) {
  var proto = this;
  /**
 * Response delegation.
 */
      Severity: Major
      Found in lib/contexts/http.js - About 2 hrs to fix

        Function done has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        HttpContext.prototype.done = function() {
  // if response is already returned, then do nothing
  if (this._done) return;
        Severity: Major
        Found in lib/contexts/http.js - About 2 hrs to fix

          Function coerceAll has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          function coerceAll(obj) {
  var type = Array.isArray(obj) ? 'array' : typeof obj;
  var i;
  var n;
          Severity: Minor
          Found in lib/contexts/http.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

            if (isint.test(str) && str.charAt(0) !== '0') return parseInt(str, 10);
          Severity: Major
          Found in lib/contexts/http.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return str;
            Severity: Major
            Found in lib/contexts/http.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                if (isfloat.test(str)) return parseFloat(str, 10);
              Severity: Major
              Found in lib/contexts/http.js - About 30 mins to fix

                Function coerce has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                function coerce(str) {
  if (typeof str !== 'string') return str;
  if ('null' === str) return null;
  if ('true' === str) return true;
  if ('false' === str) return false;
                Severity: Minor
                Found in lib/contexts/http.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function toXML has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                function toXML(input) {
  var xml;
  if (input && typeof input.toXML === 'function') {
    xml = input.toXML();
  } else {
                Severity: Minor
                Found in lib/contexts/http.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  delegate(proto, 'request')
    .method('accepts')
    .method('acceptsCharsets')
    .method('acceptsEncodings')
    .method('acceptsLanguages')
                Severity: Major
                Found in lib/contexts/http.js and 1 other location - About 7 hrs to fix
                lib/contexts/http.js on lines 74..98

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 190.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  delegate(proto, 'response')
    .getter('headersSent')
    .getter('locals')

    .method('append')
                Severity: Major
                Found in lib/contexts/http.js and 1 other location - About 7 hrs to fix
                lib/contexts/http.js on lines 104..129

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 190.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status