maa123/mastodon

View on GitHub
app/javascript/mastodon/reducers/statuses.js

Summary

Maintainability
D
2 days
Test Coverage

Function statuses has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function statuses(state = initialState, action) {
  switch(action.type) {
  case STATUS_FETCH_REQUEST:
    return state.setIn([action.id, 'isLoading'], true);
  case STATUS_FETCH_FAIL:
Severity: Major
Found in app/javascript/mastodon/reducers/statuses.js - About 2 hrs to fix

    Function statuses has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function statuses(state = initialState, action) {
      switch(action.type) {
      case STATUS_FETCH_REQUEST:
        return state.setIn([action.id, 'isLoading'], true);
      case STATUS_FETCH_FAIL:
    Severity: Minor
    Found in app/javascript/mastodon/reducers/statuses.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      case STATUS_REVEAL:
        return state.withMutations(map => {
          action.ids.forEach(id => {
            if (!(state.get(id) === undefined)) {
              map.setIn([id, 'hidden'], false);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 1 other location - About 2 hrs to fix
    app/javascript/mastodon/reducers/statuses.js on lines 114..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      case STATUS_HIDE:
        return state.withMutations(map => {
          action.ids.forEach(id => {
            if (!(state.get(id) === undefined)) {
              map.setIn([id, 'hidden'], true);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 1 other location - About 2 hrs to fix
    app/javascript/mastodon/reducers/statuses.js on lines 106..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case BOOKMARK_REQUEST:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'bookmarked'], true);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 80..81
    app/javascript/mastodon/reducers/statuses.js on lines 84..85
    app/javascript/mastodon/reducers/statuses.js on lines 88..89
    app/javascript/mastodon/reducers/statuses.js on lines 90..91
    app/javascript/mastodon/reducers/statuses.js on lines 92..93
    app/javascript/mastodon/reducers/statuses.js on lines 96..97
    app/javascript/mastodon/reducers/statuses.js on lines 100..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case UNBOOKMARK_FAIL:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'bookmarked'], true);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 80..81
    app/javascript/mastodon/reducers/statuses.js on lines 84..85
    app/javascript/mastodon/reducers/statuses.js on lines 86..87
    app/javascript/mastodon/reducers/statuses.js on lines 88..89
    app/javascript/mastodon/reducers/statuses.js on lines 90..91
    app/javascript/mastodon/reducers/statuses.js on lines 96..97
    app/javascript/mastodon/reducers/statuses.js on lines 100..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case REBLOG_FAIL:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'reblogged'], false);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 80..81
    app/javascript/mastodon/reducers/statuses.js on lines 84..85
    app/javascript/mastodon/reducers/statuses.js on lines 86..87
    app/javascript/mastodon/reducers/statuses.js on lines 88..89
    app/javascript/mastodon/reducers/statuses.js on lines 90..91
    app/javascript/mastodon/reducers/statuses.js on lines 92..93
    app/javascript/mastodon/reducers/statuses.js on lines 100..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case UNBOOKMARK_REQUEST:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'bookmarked'], false);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 80..81
    app/javascript/mastodon/reducers/statuses.js on lines 84..85
    app/javascript/mastodon/reducers/statuses.js on lines 86..87
    app/javascript/mastodon/reducers/statuses.js on lines 88..89
    app/javascript/mastodon/reducers/statuses.js on lines 92..93
    app/javascript/mastodon/reducers/statuses.js on lines 96..97
    app/javascript/mastodon/reducers/statuses.js on lines 100..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case FAVOURITE_FAIL:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'favourited'], false);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 84..85
    app/javascript/mastodon/reducers/statuses.js on lines 86..87
    app/javascript/mastodon/reducers/statuses.js on lines 88..89
    app/javascript/mastodon/reducers/statuses.js on lines 90..91
    app/javascript/mastodon/reducers/statuses.js on lines 92..93
    app/javascript/mastodon/reducers/statuses.js on lines 96..97
    app/javascript/mastodon/reducers/statuses.js on lines 100..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case BOOKMARK_FAIL:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'bookmarked'], false);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 80..81
    app/javascript/mastodon/reducers/statuses.js on lines 84..85
    app/javascript/mastodon/reducers/statuses.js on lines 86..87
    app/javascript/mastodon/reducers/statuses.js on lines 90..91
    app/javascript/mastodon/reducers/statuses.js on lines 92..93
    app/javascript/mastodon/reducers/statuses.js on lines 96..97
    app/javascript/mastodon/reducers/statuses.js on lines 100..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case UNREBLOG_FAIL:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'reblogged'], true);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 80..81
    app/javascript/mastodon/reducers/statuses.js on lines 84..85
    app/javascript/mastodon/reducers/statuses.js on lines 86..87
    app/javascript/mastodon/reducers/statuses.js on lines 88..89
    app/javascript/mastodon/reducers/statuses.js on lines 90..91
    app/javascript/mastodon/reducers/statuses.js on lines 92..93
    app/javascript/mastodon/reducers/statuses.js on lines 96..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

      case UNFAVOURITE_FAIL:
        return state.get(action.status.get('id')) === undefined ? state : state.setIn([action.status.get('id'), 'favourited'], true);
    Severity: Major
    Found in app/javascript/mastodon/reducers/statuses.js and 7 other locations - About 1 hr to fix
    app/javascript/mastodon/reducers/statuses.js on lines 80..81
    app/javascript/mastodon/reducers/statuses.js on lines 86..87
    app/javascript/mastodon/reducers/statuses.js on lines 88..89
    app/javascript/mastodon/reducers/statuses.js on lines 90..91
    app/javascript/mastodon/reducers/statuses.js on lines 92..93
    app/javascript/mastodon/reducers/statuses.js on lines 96..97
    app/javascript/mastodon/reducers/statuses.js on lines 100..101

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status