Sign upLogin

macuk/polish_invoicer

View on GitHub
Star

Showing 3 of 3 total issues

Method check_price_paid has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def check_price_paid
      return if @invoice.price_paid.nil?
      return if @invoice.price.nil?

      if @invoice.price_paid.is_a?(Numeric)
Severity: Minor
Found in lib/polish_invoicer/validator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_booleans has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def check_booleans
      unless [true, false].include?(@invoice.gross_price)
        @errors[:gross_price] = 'Znacznik rodzaju ceny musi być podany jako boolean'
      end
      @errors[:paid] = 'Znacznik opłacenia faktury musi być podany jako boolean' unless [true,
Severity: Minor
Found in lib/polish_invoicer/validator.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_dates has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def check_dates
      @errors[:create_date] = 'Data wystawienia musi być typu Date' unless @invoice.create_date.is_a?(Date)
      @errors[:trade_date] = 'Data sprzedaży musi być typu Date' unless @invoice.trade_date.is_a?(Date)
      @errors[:payment_date] = 'Termin płatności musi być typu Date' unless @invoice.payment_date.is_a?(Date)
    end
Severity: Minor
Found in lib/polish_invoicer/validator.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language