maestrano/mno-enterprise

View on GitHub
frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/affix.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function checkPosition has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  Affix.prototype.checkPosition = function () {
    if (!this.$element.is(':visible')) return

    var height       = this.$element.height()
    var offset       = this.options.offset

    Avoid too many return statements within this function.
    Open

        return false

      Avoid too many return statements within this function.
      Open

          if (offsetBottom != null && (colliderTop + colliderHeight >= scrollHeight - offsetBottom)) return 'bottom'

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          function Plugin(option) {
            return this.each(function () {
              var $this   = $(this)
              var data    = $this.data('bs.affix')
              var options = typeof option == 'object' && option
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/scrollspy.js on lines 139..148

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 9 locations. Consider refactoring.
        Open

          $.fn.affix.noConflict = function () {
            $.fn.affix = old
            return this
          }
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/alert.js on lines 83..86
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/button.js on lines 96..99
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/carousel.js on lines 199..202
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/collapse.js on lines 190..193
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/dropdown.js on lines 144..147
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/modal.js on lines 298..301
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/scrollspy.js on lines 159..162
        frontend/app/assets/javascripts/mno_enterprise/twitter/bootstrap/tab.js on lines 135..138

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status