Avoid deeply nested control flow statements.

Open

        if !result.errors.nil?
          puts "#{result.errors.size} Errors starting server (id=#{options[:server_id]} name=#{options[:server_name]})"
          result.errors.each{|error|
            puts "  #{error.message}, backtrace=#{error.backtrace}"
          }

Avoid deeply nested control flow statements.

Open

        if !result.notices.nil?
          puts "#{result.notices.size} Notices starting server (id=#{options[:server_id]} name=#{options[:server_name]})"
          result.notices.each{|notice|
            puts "  #{notice.inspect}"
          }

Avoid deeply nested control flow statements.

Open

                  if show_progress
                    @logger.info "#{indent}create_cloudflow_process(): Process state is #{state} (#{timeout-timeout_left}/#{timeout})"
                  else
                    @logger.debug "#{indent}create_cloudflow_process(): Process state is #{state} (#{timeout-timeout_left}/#{timeout})"
                  end

Avoid deeply nested control flow statements.

Open

                  if show_progress
                    @logger.info "#{indent}create_cloudflow_process(): Process state is now #{state}"
                  else
                    @logger.debug "#{indent}create_cloudflow_process(): Process state is now #{state}"
                  end

Avoid deeply nested control flow statements.

Open

      elsif options[:operation] == 'stop-server'
        result = helper.stop(options)
        if options[:wait_until_stopped]
          puts "Server (id=#{options[:server_id]} name=#{options[:server_name]}) stopped"
        else

Avoid deeply nested control flow statements.

Open

                  if timeout_reset
                    timeout_left = timeout
                    reset = true
                  end

Avoid deeply nested control flow statements.

Open

        if result.success
          if options[:wait_until_started]
            puts "Server (id=#{options[:server_id]} name=#{options[:server_name]}) started"
            instance = result.value
            puts "  resource_uid: #{instance.resource_uid}"

Method get_server has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

      def get_server
        Maestro.log.info "Retrieving RightScale server information into the Composition"
  
        # TODO: much duplication with start, but refactor after other changes for deployments land
  

• Read up
  Read up

Method validate_base_fields has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

      def validate_base_fields(missing_fields)
        if get_field('account_id').nil?
          missing_fields << 'account_id'
        end
        if get_field('refresh_token').nil? && get_field('username').nil? && get_field('password').nil?

• Read up
  Read up

Avoid too many return statements within this method.

Open

                  return Result.new(:success => false, :errors => [Exception.new("#{reponse.code} #{response}")])

Avoid too many return statements within this method.

Open

        return Result.new(:success => true, :value => instance)

Avoid too many return statements within this method.

Open

          return Result.new(:success => false, :errors => [e])

Avoid too many return statements within this method.

Open

          return Result.new(:success => false, :errors => [Exception.new('No refresh token was specified, nor was a username/password/account')])

Avoid too many return statements within this method.

Open

                  return Result.new(:success => false, :errors => [Exception.new(data['error_description'])], :value => data)

Avoid too many return statements within this method.

Open

                  return Result.new(:success => false, :errors => [Exception.new(result.to_hash['error_description'])])

Avoid too many return statements within this method.

Open

            return Result.new(:success => false, :errors => [Exception.new(e.response['error_description'])], :value => e.response)

Avoid too many return statements within this method.

Open

        return Result.new(:success => true, :value => server)

Avoid too many return statements within this method.

Open

          return Result.new(:success => false, :errors => [Exception.new(e.response['error_description'])], :value => e.response)

Avoid too many return statements within this method.

Open

                  return Result.new(:success => false, :errors => [Exception.new('CloudFlow failed to complete successfully')])

Avoid too many return statements within this method.

Open

                  return Result.new(:success => false, :errors => [Exception.new(response_hash['summary'])])