Sign upLogin

mahaplatform/backframe

View on GitHub
Star
src/utils/filter_sort.js

Summary

Maintainability
D
2 days
Test Coverage

FilterSort has 30 functions (exceeds 20 allowed). Consider refactoring.
Open

class FilterSort {

  defaultQuery = null

  defaultSort = null
Severity: Minor
Found in src/utils/filter_sort.js - About 3 hrs to fix

    Function _filterDateRange has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      _filterDateRange(qb, column, value) {

    if(value === 'this_week') {

      this._filterRange(qb, column, 0, 'week')
    Severity: Minor
    Found in src/utils/filter_sort.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _filterDateRange has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _filterDateRange(qb, column, value) {

    if(value === 'this_week') {

      this._filterRange(qb, column, 0, 'week')
    Severity: Minor
    Found in src/utils/filter_sort.js - About 1 hr to fix

      Function _filterColumn has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        _filterColumn(qb, column, filter) {

    if(filter.$eq) {

      this._filterEqual(qb, column, filter.$eq)
      Severity: Minor
      Found in src/utils/filter_sort.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function apply has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        apply(req, trx, qb, options) {

    const tableName = this.model.extend().__super__.tableName

    const filters = this._getAllowedFilters(req.query.$filter, this.filterParams)
      Severity: Minor
      Found in src/utils/filter_sort.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          if(value.match(/^\d*$/)) return qb.where(column, value)
      Severity: Major
      Found in src/utils/filter_sort.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return qb.whereRaw(`lower(${column}) = ?`, value.toLowerCase())
        Severity: Major
        Found in src/utils/filter_sort.js - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _filterIn(qb, column, value) {

    const inArray = _.without(value, 'null')

    if(!_.includes(value, 'null')) return qb.whereIn(column, inArray)
          Severity: Major
          Found in src/utils/filter_sort.js and 1 other location - About 2 hrs to fix
          src/utils/filter_sort.js on lines 261..273

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _filterNotIn(qb, column, value) {

    const inArray = _.without(value, 'null')

    if(!_.includes(value, 'null')) return qb.whereNotIn(column, inArray)
          Severity: Major
          Found in src/utils/filter_sort.js and 1 other location - About 2 hrs to fix
          src/utils/filter_sort.js on lines 247..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status