Sign upLogin

makeomatic/mservice-calendar

View on GitHub
Star
src/services/storage.js

Summary

Maintainability
C
1 day
Test Coverage

File storage.js has 278 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * services/storage.js
 */

const Promise = require('bluebird');
Severity: Minor
Found in src/services/storage.js - About 2 hrs to fix

    Function listEventSubs has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      listEventSubs(filters) {
    let startTime = filters.startTime ? moment.utc(filters.startTime) : moment.utc();
    let endTime = filters.endTime ? moment.utc(filters.endTime) : moment.utc().add(1, 'years');

    startTime = startTime.toISOString();
    Severity: Minor
    Found in src/services/storage.js - About 1 hr to fix

      Function getEvents has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        getEvents(filter) {
    const { owner, tags, hosts } = filter;
    const knex = this.client;

    const startTime = new Date(filter.startTime).toISOString();
      Severity: Minor
      Found in src/services/storage.js - About 1 hr to fix

        Function createEvent has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          createEvent(data) {
    // won't be more than 365 e vents due to constraints we have
    const knex = this.client;
    const resultingEvent = pick(data, EVENT_FIELDS);
        Severity: Minor
        Found in src/services/storage.js - About 1 hr to fix

          Function getEventTags has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            getEventTags(filter) {
    const knex = this.client;
    const isActive = filter.active;
    const startTime = filter.startTime || new Date().toISOString();
    const endTime = filter.endTime || moment().add(2, 'month').toISOString();
          Severity: Minor
          Found in src/services/storage.js - About 1 hr to fix

            TODO found
            Open

                // TODO: assert that we do not request something 1 year from now
            Severity: Minor
            Found in src/services/storage.js by fixme

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  query
        .joinRaw(`INNER JOIN ${EVENT_TABLE} on ${EVENT_TABLE}.tags @> ARRAY[${EVENT_TAGS_TABLE}.id]`)
        .joinRaw((`INNER JOIN ${EVENT_SPANS_TABLE} on (`
          + `${EVENT_TABLE}.id = ${EVENT_SPANS_TABLE}.event_id AND `
          + `${EVENT_SPANS_TABLE}.period && tsrange(TIMESTAMP '${startTime}', TIMESTAMP '${endTime}')`
            Severity: Minor
            Found in src/services/storage.js and 1 other location - About 55 mins to fix
            src/services/storage.js on lines 195..213

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                const query = knex
      .select([
        'id',
        'title',
        'description',
            Severity: Minor
            Found in src/services/storage.js and 1 other location - About 55 mins to fix
            src/services/storage.js on lines 340..346

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 53.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status