Sign upLogin

mambax7/cardealer

View on GitHub
Star

Showing 25 of 664 total issues

Avoid deeply nested control flow statements.
Open

                            if (file_exists($templateFolder . $v)) {
                                unlink($templateFolder . $v);
                            }
Severity: Major
Found in include/onupdate.php - About 45 mins to fix

    Method truncateHtml has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function truncateHtml($text, $length = 100, $ending = '...', $exact = false, $considerHtml = true)
    Severity: Minor
    Found in class/Utility.php - About 35 mins to fix

      Method cardealer_search has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      function cardealer_search($queryarray, $andor, $limit, $offset, $userid)
      Severity: Minor
      Found in include/search.inc.php - About 35 mins to fix

        Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct($target)
    {
        global $helper;
        $this->targetObject = $target;
        Severity: Minor
        Found in class/Form/PartForm.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function cardealer_search has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        function cardealer_search($queryarray, $andor, $limit, $offset, $userid)
{
    $sql = 'SELECT custnum, custname FROM ' . $GLOBALS['xoopsDB']->prefix('cardealer_customer') . ' WHERE _online = 1';

    if (0 !== $userid) {
        Severity: Minor
        Found in include/search.inc.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language