Sign upLogin

mambax7/extgallery

View on GitHub
Star
assets/js/galleryview/timers.js

Summary

Maintainability
C
1 day
Test Coverage

Function remove has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

        remove: function(element, label, fn) {
            var timers = jQuery.data(element, this.dataKey), ret;

            if ( timers ) {
Severity: Minor
Found in assets/js/galleryview/timers.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function add has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        add: function(element, interval, label, fn, times) {
            var counter = 0;

            if (jQuery.isFunction(label)) {
                if (!times)
Severity: Minor
Found in assets/js/galleryview/timers.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function remove has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        remove: function(element, label, fn) {
            var timers = jQuery.data(element, this.dataKey), ret;

            if ( timers ) {
Severity: Minor
Found in assets/js/galleryview/timers.js - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                            for ( var fn in timers[label] ) {
                            window.clearInterval(timers[label][fn]);
                            delete timers[label][fn];
                        }
    Severity: Major
    Found in assets/js/galleryview/timers.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if ( fn.timerID ) {
                            window.clearInterval(timers[label][fn.timerID]);
                            delete timers[label][fn.timerID];
                        }
      Severity: Major
      Found in assets/js/galleryview/timers.js - About 45 mins to fix

        Function add has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                add: function(element, interval, label, fn, times) {
        Severity: Minor
        Found in assets/js/galleryview/timers.js - About 35 mins to fix

          There are no issues that match your filters.

          Category
          Status