mambax7/moduleinstaller

View on GitHub

Showing 122 of 198 total issues

Function request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    request: function (form, options) {
        form = $(form), options = Object.clone(options || {});

        var params = options.parameters, action = form.readAttribute('action') || '';
        if (action.blank()) action = window.location.href;
Severity: Minor
Found in assets/js/prototype.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function xoopsExternalLinks has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

function xoopsExternalLinks() {
    if (!document.getElementsByTagName) return;
    var anchors = document.getElementsByTagName("a");
    for (var i = 0; i < anchors.length; i++) {
        var anchor = anchors[i];
Severity: Minor
Found in assets/js/xo-installer.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

                    return results;
Severity: Major
Found in assets/js/prototype.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                        return results;
    Severity: Major
    Found in assets/js/prototype.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return compare & 4 ? -1 : 1;
      Severity: Major
      Found in assets/js/prototype.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return 0;
        Severity: Major
        Found in assets/js/prototype.js - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in class/InstallWizard.php - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return value;
            Severity: Major
            Found in assets/js/prototype.js - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return true;
              Severity: Major
              Found in class/InstallWizard.php - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                            return results;
                Severity: Major
                Found in assets/js/prototype.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                      return sortInput ?
                                          (indexOf.call(sortInput, a) - indexOf.call(sortInput, b)) :
                                          0;
                  Severity: Major
                  Found in assets/js/prototype.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return false;
                    Severity: Major
                    Found in assets/js/prototype.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                              return results;
                      Severity: Major
                      Found in assets/js/prototype.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return select(selector.replace(rtrim, "$1"), context, results, seed);
                        Severity: Major
                        Found in assets/js/prototype.js - About 30 mins to fix

                          Function loadSampleData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function loadSampleData(): void
                          {
                              global $xoopsConfig;
                              $moduleDirName      = \basename(\dirname(__DIR__));
                              $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
                          Severity: Minor
                          Found in testdata/index.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              initialize: function (request) {
                                  this.request = request;
                                  var transport = this.transport = request.transport,
                                      readyState = this.readyState = transport.readyState;
                          
                          
                          Severity: Minor
                          Found in assets/js/prototype.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function xoops_module_deactivate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function xoops_module_deactivate($mid)
                          {
                              global $xoopsConfig;
                              // Get module handler
                              /** @var \XoopsModuleHandler $moduleHandler */
                          Severity: Minor
                          Found in extras/modulesadmin.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function xoops_module_uninstall_moduleinstaller has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function xoops_module_uninstall_moduleinstaller(\XoopsModule $module)
                          {
                              //    return true;
                          
                              $moduleDirName      = \basename(\dirname(__DIR__));
                          Severity: Minor
                          Found in include/onuninstall.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function ObjectRange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          var ObjectRange = Class.create(Enumerable, (function () {
                              function initialize(start, end, exclusive) {
                                  this.start = start;
                                  this.end = end;
                                  this.exclusive = exclusive;
                          Severity: Minor
                          Found in assets/js/prototype.js - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function xoops_module_gettemplate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                          function &xoops_module_gettemplate($dirname, $template, $type = '')
                          {
                              global $xoopsConfig;
                              $ret = '';
                              switch ($type) {
                          Severity: Minor
                          Found in extras/modulesadmin.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Severity
                          Category
                          Status
                          Source
                          Language