mambax7/smartobject

View on GitHub
include/addto/addto.js

Summary

Maintainability
D
2 days
Test Coverage

Function addto has 120 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function addto(addsite) {
    switch (addsite) {
        case 0: //  AddToBookmarks.com ID:0 - an educational page on what Social Bookmarking is
            var AddSite = "http://www.addtobookmarks.com/socialbookmarking.htm?";
            var AddUrlVar = "url";
Severity: Major
Found in include/addto/addto.js - About 4 hrs to fix

    Function addtoWin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function addtoWin(addtoFullURL, width, height) {
        if (!popupWin.closed && popupWin.location) {
            popupWin.location.href = addtoFullURL;
            intervalMgr();
        }
    Severity: Minor
    Found in include/addto/addto.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 8: //  Spurl ID: 8     d.selection?d.selection.createRange().text:d.getSelection()
                var AddSite = "http://www.spurl.net/spurl.php?";
                var AddUrlVar = "url";
                var AddTitleVar = "title";
                var AddNoteVar = "blocked";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 204..213

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 0: //  AddToBookmarks.com ID:0 - an educational page on what Social Bookmarking is
                var AddSite = "http://www.addtobookmarks.com/socialbookmarking.htm?";
                var AddUrlVar = "url";
                var AddTitleVar = "title";
                var AddNoteVar = "";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 204..213
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 3: //  Digg ID:3
                var AddSite = "http://digg.com/submit?";
                var AddUrlVar = "url";
                var AddTitleVar = "";
                var AddNoteVar = "";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 204..213
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 5: //  GOOGLE ID:5
                var AddSite = "http://www.google.com/bookmarks/mark?op=add&";
                var AddUrlVar = "bkmk";
                var AddTitleVar = "title";
                var AddNoteVar = "";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 204..213
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 7: //  Yahoo ID: 7
                var AddSite = "http://myweb2.search.yahoo.com/myresults/bookmarklet?";
                var AddUrlVar = "u";
                var AddTitleVar = "t";
                var AddNoteVar = "";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 1: //  Blink ID:1
                var AddSite = "http://www.blinklist.com/index.php?Action=Blink/addblink.php";
                var AddUrlVar = "url";
                var AddTitleVar = "title";
                var AddNoteVar = "description";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 204..213
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 4: //  Furl ID:4
                var AddSite = "http://www.furl.net/savedialog.jsp?";
                var AddUrlVar = "u";
                var AddTitleVar = "t";
                var AddNoteVar = "";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 204..213
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 6: //  Simpy ID:6
                var AddSite = "http://simpy.com/simpy/LinkAdd.do?";
                var AddUrlVar = "href";
                var AddTitleVar = "title";
                var AddNoteVar = "note";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 154..163
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 204..213
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            case 2: //  Del.icio.us ID:2 &v=3&noui=yes&jump=close
                var AddSite = "http://del.icio.us/post?";
                var AddUrlVar = "url";
                var AddTitleVar = "title";
                var AddNoteVar = "";
    Severity: Major
    Found in include/addto/addto.js and 8 other locations - About 1 hr to fix
    include/addto/addto.js on lines 134..143
    include/addto/addto.js on lines 144..153
    include/addto/addto.js on lines 164..173
    include/addto/addto.js on lines 174..183
    include/addto/addto.js on lines 184..193
    include/addto/addto.js on lines 194..203
    include/addto/addto.js on lines 204..213
    include/addto/addto.js on lines 214..223

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status