Sign upLogin

mambax7/smartobject

View on GitHub
Star
include/projax/js/slider.js

Summary

Maintainability
F
3 wks
Test Coverage

Function initialize has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    initialize: function (handle, track, options) {
        var slider = this;

        if (handle instanceof Array) {
            this.handles = handle.collect(function (e) {
Severity: Major
Found in include/projax/js/slider.js - About 2 hrs to fix

    prototype has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    Control.Slider.prototype = {
    initialize: function (handle, track, options) {
        var slider = this;

        if (handle instanceof Array) {
    Severity: Minor
    Found in include/projax/js/slider.js - About 2 hrs to fix

      Function startDrag has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          startDrag: function (event) {
        if (Event.isLeftClick(event)) {
            if (!this.disabled) {
                this.active = true;
      Severity: Minor
      Found in include/projax/js/slider.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          initialize: function (handle, track, options) {
        var slider = this;

        if (handle instanceof Array) {
            this.handles = handle.collect(function (e) {
      Severity: Minor
      Found in include/projax/js/slider.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function startDrag has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          startDrag: function (event) {
        if (Event.isLeftClick(event)) {
            if (!this.disabled) {
                this.active = true;
      Severity: Minor
      Found in include/projax/js/slider.js - About 1 hr to fix

        Function setValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            setValue: function (sliderValue, handleIdx) {
        if (!this.active) {
            this.activeHandleIdx = handleIdx || 0;
            this.activeHandle = this.handles[this.activeHandleIdx];
            this.updateStyles();
        Severity: Minor
        Found in include/projax/js/slider.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getNearestValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            getNearestValue: function (value) {
        if (this.allowedValues) {
            if (value >= this.allowedValues.max()) return (this.allowedValues.max());
            if (value <= this.allowedValues.min()) return (this.allowedValues.min());
        Severity: Minor
        Found in include/projax/js/slider.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function drawSpans has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            drawSpans: function () {
        var slider = this;
        if (this.spans)
            $R(0, this.spans.length - 1).each(function (r) {
                slider.setSpan(slider.spans[r], slider.getRange(r))
        Severity: Minor
        Found in include/projax/js/slider.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

                return value;
        Severity: Major
        Found in include/projax/js/slider.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  if (value < this.range.start) return this.range.start;
          Severity: Major
          Found in include/projax/js/slider.js - About 30 mins to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

            Control.Slider.prototype = {
    initialize: function (handle, track, options) {
        var slider = this;

        if (handle instanceof Array) {
            Severity: Major
            Found in include/projax/js/slider.js and 2 other locations - About 3 wks to fix
            include/projax_/js/slider.js on lines 35..304
            include/scriptaculous/src/slider.js on lines 35..304

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 3830.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status