manshar/manshar

View on GitHub
web-client/app/scripts/directives/loadMoreData.js

Summary

Maintainability
C
1 day
Test Coverage

Function link has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      link: function(scope, element) {
        var page = 1;
        scope.hasNext = true;
        scope.inProgress = false;

Severity: Major
Found in web-client/app/scripts/directives/loadMoreData.js - About 3 hrs to fix

    Function loadMoreData has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            scope.loadMoreData = function() {
              scope.inProgress = true;
    
              if(scope.state === 'publishers') {
                User.query({
    Severity: Minor
    Found in web-client/app/scripts/directives/loadMoreData.js - About 2 hrs to fix

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                  } else if(scope.state === 'discussions') {
                    UserComment.query({
                      'userId': scope.profile.id,
                      'page': ++page,
                      'order': scope.order
      Severity: Major
      Found in web-client/app/scripts/directives/loadMoreData.js and 4 other locations - About 35 mins to fix
      web-client/app/scripts/directives/loadMoreData.js on lines 74..111
      web-client/app/scripts/directives/loadMoreData.js on lines 81..105
      web-client/app/scripts/directives/loadMoreData.js on lines 87..105
      web-client/app/scripts/directives/loadMoreData.js on lines 99..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                  } else if(scope.state === 'drafts') {
                    UserDraft.query({
                      'userId': scope.profile.id,
                      'page': ++page,
                      'order': scope.order
      Severity: Major
      Found in web-client/app/scripts/directives/loadMoreData.js and 4 other locations - About 35 mins to fix
      web-client/app/scripts/directives/loadMoreData.js on lines 74..111
      web-client/app/scripts/directives/loadMoreData.js on lines 81..105
      web-client/app/scripts/directives/loadMoreData.js on lines 87..105
      web-client/app/scripts/directives/loadMoreData.js on lines 93..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                } else if(scope.category) {
                  CategoryArticle.query({
                    'categoryId': scope.category.id,
                    'page': ++page,
                    'order': scope.order
      Severity: Major
      Found in web-client/app/scripts/directives/loadMoreData.js and 4 other locations - About 35 mins to fix
      web-client/app/scripts/directives/loadMoreData.js on lines 81..105
      web-client/app/scripts/directives/loadMoreData.js on lines 87..105
      web-client/app/scripts/directives/loadMoreData.js on lines 93..105
      web-client/app/scripts/directives/loadMoreData.js on lines 99..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                  } else if(scope.state === 'recommended') {
                    UserRecommendation.query({
                      'userId': scope.profile.id,
                      'page': ++page,
                      'order': scope.order
      Severity: Major
      Found in web-client/app/scripts/directives/loadMoreData.js and 4 other locations - About 35 mins to fix
      web-client/app/scripts/directives/loadMoreData.js on lines 74..111
      web-client/app/scripts/directives/loadMoreData.js on lines 81..105
      web-client/app/scripts/directives/loadMoreData.js on lines 93..105
      web-client/app/scripts/directives/loadMoreData.js on lines 99..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

                  if(scope.state === 'published') {
                    UserArticle.query({
                      'userId': scope.profile.id,
                      'page': ++page,
                      'order': scope.order
      Severity: Major
      Found in web-client/app/scripts/directives/loadMoreData.js and 4 other locations - About 35 mins to fix
      web-client/app/scripts/directives/loadMoreData.js on lines 74..111
      web-client/app/scripts/directives/loadMoreData.js on lines 87..105
      web-client/app/scripts/directives/loadMoreData.js on lines 93..105
      web-client/app/scripts/directives/loadMoreData.js on lines 99..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status