Sign upLogin

manshar/manshar

View on GitHub
Star
web-client/app/scripts/services/imageService.js

Summary

Maintainability
C
1 day
Test Coverage

Function save has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        save: function (data, optSuccess, optError, optProgress) {

          var delayedObj = {};

          // TODO(mkhatib): Until we figure out a way to rename files either
Severity: Minor
Found in web-client/app/scripts/services/imageService.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            update: function (params, data, optSuccess, optError) {

          var delayedObj = {};

          $http.put(baseUrl + 'images/' + params.imageId,
    Severity: Major
    Found in web-client/app/scripts/services/imageService.js and 1 other location - About 4 hrs to fix
    web-client/app/scripts/services/categoryService.js on lines 68..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 131.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

          var createFormData = function (data) {
        var fd = new FormData();
        for (var key in data.image) {
          // Remove special keys for angular resources.
          if (key.trim() === '' || key.indexOf('$') === 0 || key === 'toJSON') {
    Severity: Major
    Found in web-client/app/scripts/services/imageService.js and 3 other locations - About 4 hrs to fix
    web-client/app/scripts/services/articleService.js on lines 25..35
    web-client/app/scripts/services/categoryService.js on lines 23..33
    web-client/app/scripts/services/userService.js on lines 33..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          var ImageResource = $resource(baseUrl + 'images/:imageId', {}, {
        get: {cache: true},
        query: {cache: true, isArray: true}
      });
    Severity: Minor
    Found in web-client/app/scripts/services/imageService.js and 1 other location - About 40 mins to fix
    web-client/app/scripts/services/categoryService.js on lines 8..11

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status