mar10/fancytree

View on GitHub
demo/taxonomy-browser/taxonomy-browser.js

Summary

Maintainability
F
3 days
Test Coverage

File taxonomy-browser.js has 401 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * Fancytree Taxonomy Browser
 *
 * Copyright (c) 2015, Martin Wendt (https://wwWendt.de)
 *
Severity: Minor
Found in demo/taxonomy-browser/taxonomy-browser.js - About 5 hrs to fix

    Function updateBreadcrumb has 54 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function updateBreadcrumb(key, loadTreeNodes) {
            var $ol = $("ol.breadcrumb").addClass("busy"),
                activeNode = taxonTree.getActiveNode();
    
            if (activeNode && activeNode.key !== key) {
    Severity: Major
    Found in demo/taxonomy-browser/taxonomy-browser.js - About 2 hrs to fix

      Function updateItemDetails has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function updateItemDetails(key) {
              $("#tmplDetails").addClass("busy");
              $.bbq.pushState({ key: key });
      
              $.when(
      Severity: Minor
      Found in demo/taxonomy-browser/taxonomy-browser.js - About 1 hr to fix

        Function postProcess has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    postProcess: function (event, data) {
                        var response = data.response;
        
                        data.node.info("search postProcess", response);
                        data.result = $.map(response.results, function (o) {
        Severity: Minor
        Found in demo/taxonomy-browser/taxonomy-browser.js - About 1 hr to fix

          Function renderColumns has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      renderColumns: function (event, data) {
                          var i,
                              node = data.node,
                              $tdList = $(node.tr).find(">td"),
                              cnList = node.data.vernacularNames
          Severity: Minor
          Found in demo/taxonomy-browser/taxonomy-browser.js - About 1 hr to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                function updateControls() {
                    var query = $.trim($("input[name=query]").val());
            
                    $("#btnPin").attr("disabled", !taxonTree.getActiveNode());
                    $("#btnUnpin")
            Severity: Major
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 5 hrs to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 46..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 152.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                function _delay(tag, ms, callback) {
                    /*jshint -W040:true */
                    var self = this;
            
                    tag = "" + (tag || "default");
            Severity: Major
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 5 hrs to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 61..79

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 136.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $(window).on("hashchange", function (e) {
                        var key = $.bbq.getState("key");
                        console.log("bbq key", key);
                        if (key) {
                            updateBreadcrumb(key, true);
            Severity: Major
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 1 hr to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 346..352

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 73.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    $("#btnSearch")
                        .click(function (event) {
                            $("#searchResultPane").collapse("show");
                            search($("input[name=query]").val());
                        })
            Severity: Major
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 1 hr to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 380..385

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 63.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (e && e.which === $.ui.keyCode.ENTER && query.length >= 2) {
                                $("#btnSearch").trigger("click");
                                return;
                            }
            Severity: Major
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 1 hr to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 362..365

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 59.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            if ((e && e.which === $.ui.keyCode.ESCAPE) || query === "") {
                                $("#btnResetSearch").trigger("click");
                                return;
                            }
            Severity: Major
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 1 hr to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 358..361

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    $("#btnPin").click(function (event) {
                        taxonTree.filterBranches(function (n) {
                            return n.isActive();
                        });
                        updateControls();
            Severity: Minor
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 55 mins to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 387..392

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                cnList = node.data.vernacularNames
                                    ? $.map(node.data.vernacularNames, function (o) {
                                            return o.vernacularName;
                                      })
                                    : [];
            Severity: Minor
            Found in demo/taxonomy-browser/taxonomy-browser.js and 1 other location - About 45 mins to fix
            demo/taxonomy-browser/taxonomy-browser-itis.js on lines 322..326

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status