Sign upLogin

mar10/fancytree

View on GitHub
Star
src/jquery.fancytree.dnd.js

Summary

Maintainability
F
5 days
Test Coverage

File jquery.fancytree.dnd.js has 627 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jquery.fancytree.dnd.js
 *
 * Drag-and-drop support (jQuery UI draggable/droppable).
 * (Extension module for jquery.fancytree.js: https://github.com/mar10/fancytree/)
Severity: Major
Found in src/jquery.fancytree.dnd.js - About 1 day to fix

    Function _onDragEvent has 224 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            _onDragEvent: function (
            eventName,
            node,
            otherNode,
            event,
    Severity: Major
    Found in src/jquery.fancytree.dnd.js - About 1 day to fix

      Function _registerDnd has 141 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function _registerDnd() {
        if (didRegisterDnd) {
            return;
        }
      Severity: Major
      Found in src/jquery.fancytree.dnd.js - About 5 hrs to fix

        Function _initDragAndDrop has 85 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function _initDragAndDrop(tree) {
        var dnd = tree.options.dnd || null,
            glyph = tree.options.glyph || null;

        // Register 'connectToFancytree' option with ui.draggable
        Severity: Major
        Found in src/jquery.fancytree.dnd.js - About 3 hrs to fix

          Function _setDndStatus has 76 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  _setDndStatus: function (
            sourceNode,
            targetNode,
            helper,
            hitMode,
          Severity: Major
          Found in src/jquery.fancytree.dnd.js - About 3 hrs to fix

            Function drag has 72 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                        drag: function (event, ui) {
                var ctx,
                    isHelper,
                    logObject,
                    // 'draggable' was renamed to 'ui-draggable' since jQueryUI 1.10
            Severity: Major
            Found in src/jquery.fancytree.dnd.js - About 2 hrs to fix

              Function helper has 43 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                                      helper: function (event) {
                            var $helper,
                                $nodeTag,
                                opts,
                                sourceNode = $.ui.fancytree.getNode(
              Severity: Minor
              Found in src/jquery.fancytree.dnd.js - About 1 hr to fix

                Function stop has 41 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            stop: function (event, ui) {
                var logObject,
                    // 'draggable' was renamed to 'ui-draggable' since jQueryUI 1.10:
                    draggable =
                        $(this).data("ui-draggable") ||
                Severity: Minor
                Found in src/jquery.fancytree.dnd.js - About 1 hr to fix

                  Consider simplifying this complex logical expression.
                  Open

                                      if (
                        hitMode !== "before" &&
                        hitMode !== "after" &&
                        dnd.autoExpandMS &&
                        node.hasChildren() !== false &&
                  Severity: Major
                  Found in src/jquery.fancytree.dnd.js - About 1 hr to fix

                    Function _onDragEvent has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                                eventName,
            node,
            otherNode,
            event,
            ui,
                    Severity: Minor
                    Found in src/jquery.fancytree.dnd.js - About 45 mins to fix

                      Consider simplifying this complex logical expression.
                      Open

                                  if (
                hitMode === "after" ||
                hitMode === "before" ||
                hitMode === "over"
            ) {
                      Severity: Major
                      Found in src/jquery.fancytree.dnd.js - About 40 mins to fix

                        Function _setDndStatus has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                    sourceNode,
            targetNode,
            helper,
            hitMode,
            accept
                        Severity: Minor
                        Found in src/jquery.fancytree.dnd.js - About 35 mins to fix

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              } else if (Array.isArray(r)) {
                        // TODO: also accept passing an object of this format directly
                        res = {
                            over: $.inArray("over", r) >= 0,
                            before: $.inArray("before", r) >= 0,
                          Severity: Major
                          Found in src/jquery.fancytree.dnd.js and 1 other location - About 1 hr to fix
                          src/jquery.fancytree.dnd5.js on lines 118..130

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 63.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                                  res = {
                            over: $.inArray("over", r) >= 0,
                            before: $.inArray("before", r) >= 0,
                            after: $.inArray("after", r) >= 0,
                        };
                          Severity: Major
                          Found in src/jquery.fancytree.dnd.js and 1 other location - About 1 hr to fix
                          src/jquery.fancytree.dnd5.js on lines 119..123

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 61.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          switch (hitMode) {
                    case "before":
                        markerAt = "top";
                        markerOffsetX += dndOpt.dropMarkerInsertOffsetX || 0;
                        break;
                          Severity: Major
                          Found in src/jquery.fancytree.dnd.js and 1 other location - About 1 hr to fix
                          src/jquery.fancytree.dnd5.js on lines 501..510

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 58.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status