mar10/fancytree

View on GitHub
src/jquery.fancytree.filter.js

Summary

Maintainability
D
2 days
Test Coverage

Function _applyFilterImpl has 167 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    $.ui.fancytree._FancytreeClass.prototype._applyFilterImpl = function (
        filter,
        branchMode,
        _opts
    ) {
Severity: Major
Found in src/jquery.fancytree.filter.js - About 6 hrs to fix

    File jquery.fancytree.filter.js has 404 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*!
     * jquery.fancytree.filter.js
     *
     * Remove or highlight tree nodes, based on a filter.
     * (Extension module for jquery.fancytree.js: https://github.com/mar10/fancytree/)
    Severity: Minor
    Found in src/jquery.fancytree.filter.js - About 5 hrs to fix

      Function nodeRenderStatus has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              nodeRenderStatus: function (ctx) {
                  // Set classes for current status
                  var res,
                      node = ctx.node,
                      tree = ctx.tree,
      Severity: Major
      Found in src/jquery.fancytree.filter.js - About 2 hrs to fix

        Function clearFilter has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            $.ui.fancytree._FancytreeClass.prototype.clearFilter = function () {
                var $title,
                    statusNode = this.getRootNode()._findDirectChild(KeyNoData),
                    escapeTitles = this.options.escapeTitles,
                    enhanceTitle = this.options.enhanceTitle,
        Severity: Minor
        Found in src/jquery.fancytree.filter.js - About 1 hr to fix

          Similar blocks of code found in 16 locations. Consider refactoring.
          Open

          (function (factory) {
              if (typeof define === "function" && define.amd) {
                  // AMD. Register as an anonymous module.
                  define(["jquery", "./jquery.fancytree"], factory);
              } else if (typeof module === "object" && module.exports) {
          Severity: Major
          Found in src/jquery.fancytree.filter.js and 15 other locations - About 3 hrs to fix
          src/jquery.fancytree.childcounter.js on lines 31..241
          src/jquery.fancytree.clones.js on lines 16..514
          src/jquery.fancytree.columnview.js on lines 16..205
          src/jquery.fancytree.dnd5.js on lines 29..1157
          src/jquery.fancytree.edit.js on lines 16..403
          src/jquery.fancytree.glyph.js on lines 16..354
          src/jquery.fancytree.grid.js on lines 16..1014
          src/jquery.fancytree.js on lines 18..7378
          src/jquery.fancytree.logger.js on lines 16..309
          src/jquery.fancytree.menu.js on lines 18..185
          src/jquery.fancytree.multi.js on lines 16..128
          src/jquery.fancytree.persist.js on lines 18..513
          src/jquery.fancytree.table.js on lines 16..545
          src/jquery.fancytree.themeroller.js on lines 18..125
          src/jquery.fancytree.wide.js on lines 15..257

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 105.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status