mar10/fancytree

View on GitHub
src/jquery.fancytree.grid.js

Summary

Maintainability
F
6 days
Test Coverage

File jquery.fancytree.grid.js has 688 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jquery.fancytree.grid.js
 *
 * Render tree as table (aka 'tree grid', 'table tree').
 * (Extension module for jquery.fancytree.js: https://github.com/mar10/fancytree/)
Severity: Major
Found in src/jquery.fancytree.grid.js - About 1 day to fix

    Function treeInit has 131 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            treeInit: function (ctx) {
                var i,
                    columnCount,
                    n,
                    $row,
    Severity: Major
    Found in src/jquery.fancytree.grid.js - About 5 hrs to fix

      Function setViewport has 77 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          $.ui.fancytree._FancytreeClass.prototype.setViewport = function (opts) {
              if (typeof opts === "boolean") {
                  this.debug("setViewport( " + opts + ")");
                  return this.setViewport({ enabled: opts });
              }
      Severity: Major
      Found in src/jquery.fancytree.grid.js - About 3 hrs to fix

        Function nodeRender has 70 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                nodeRender: function (ctx, force, deep, collapsed, _recursive) {
                    var children,
                        i,
                        l,
                        outsideViewport,
        Severity: Major
        Found in src/jquery.fancytree.grid.js - About 2 hrs to fix

          Function nodeSetExpanded has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  nodeSetExpanded: function (ctx, flag, callOpts) {
                      var node = ctx.node,
                          tree = ctx.tree;
          
                      // flag defaults to true
          Severity: Major
          Found in src/jquery.fancytree.grid.js - About 2 hrs to fix

            Function redrawViewport has 41 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                $.ui.fancytree._FancytreeClass.prototype.redrawViewport = function (force) {
                    if (this._enableUpdate === false) {
                        // tree.debug("no render", tree._enableUpdate);
                        return;
                    }
            Severity: Minor
            Found in src/jquery.fancytree.grid.js - About 1 hr to fix

              Function _afterExpand has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                          function _afterExpand(ok) {
                              tree.redrawViewport(true);
              
                              if (ok) {
                                  if (
              Severity: Minor
              Found in src/jquery.fancytree.grid.js - About 1 hr to fix

                Function nodeRenderTitle has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        nodeRenderTitle: function (ctx, title) {
                            var $cb,
                                res,
                                tree = ctx.tree,
                                node = ctx.node,
                Severity: Minor
                Found in src/jquery.fancytree.grid.js - About 1 hr to fix

                  Function nodeKeydown has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          nodeKeydown: function (ctx) {
                              var nextNode = null,
                                  nextIdx = null,
                                  tree = ctx.tree,
                                  node = ctx.node,
                  Severity: Minor
                  Found in src/jquery.fancytree.grid.js - About 1 hr to fix

                    Function _initViewportWrapper has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            function () {
                                var // wrapper = this.scrollWrapper,
                                    // $wrapper = $(wrapper),
                                    tree = this;
                    
                    
                    Severity: Minor
                    Found in src/jquery.fancytree.grid.js - About 1 hr to fix

                      Function nodeRender has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              nodeRender: function (ctx, force, deep, collapsed, _recursive) {
                      Severity: Minor
                      Found in src/jquery.fancytree.grid.js - About 35 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                                return false;
                        Severity: Major
                        Found in src/jquery.fancytree.grid.js - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  nodeRenderStatus: function (ctx) {
                                      var indent,
                                          node = ctx.node,
                                          opts = ctx.options;
                          
                          
                          Severity: Major
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 6 hrs to fix
                          src/jquery.fancytree.table.js on lines 427..442

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 171.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 16 locations. Consider refactoring.
                          Open

                          (function (factory) {
                              if (typeof define === "function" && define.amd) {
                                  // AMD. Register as an anonymous module.
                                  define(["jquery", "./jquery.fancytree"], factory);
                              } else if (typeof module === "object" && module.exports) {
                          Severity: Major
                          Found in src/jquery.fancytree.grid.js and 15 other locations - About 3 hrs to fix
                          src/jquery.fancytree.childcounter.js on lines 31..241
                          src/jquery.fancytree.clones.js on lines 16..514
                          src/jquery.fancytree.columnview.js on lines 16..205
                          src/jquery.fancytree.dnd5.js on lines 29..1157
                          src/jquery.fancytree.edit.js on lines 16..403
                          src/jquery.fancytree.filter.js on lines 16..549
                          src/jquery.fancytree.glyph.js on lines 16..354
                          src/jquery.fancytree.js on lines 18..7378
                          src/jquery.fancytree.logger.js on lines 16..309
                          src/jquery.fancytree.menu.js on lines 18..185
                          src/jquery.fancytree.multi.js on lines 16..128
                          src/jquery.fancytree.persist.js on lines 18..513
                          src/jquery.fancytree.table.js on lines 16..545
                          src/jquery.fancytree.themeroller.js on lines 18..125
                          src/jquery.fancytree.wide.js on lines 15..257

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 105.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if (
                                          opts.checkbox &&
                                          !isStatusNode &&
                                          opts.table.checkboxColumnIdx != null
                                      ) {
                          Severity: Major
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 3 hrs to fix
                          src/jquery.fancytree.table.js on lines 390..400

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 102.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if (!$tbody.length) {
                                          // TODO: not sure if we can rely on browsers to insert missing <tbody> before <tr>s:
                                          if ($table.find(">tr").length) {
                                              $.error(
                                                  "Expected table > tbody > tr. If you see this, please open an issue."
                          Severity: Major
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 1 hr to fix
                          src/jquery.fancytree.table.js on lines 134..142

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 64.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      var $cb,
                                          res,
                                          tree = ctx.tree,
                                          node = ctx.node,
                                          opts = ctx.options,
                          Severity: Minor
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 35 mins to fix
                          src/jquery.fancytree.table.js on lines 377..382

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 47.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                              if (
                                                  flag &&
                                                  ctx.options.autoScroll &&
                                                  !callOpts.noAnimation &&
                                                  node.hasChildren()
                          Severity: Minor
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 35 mins to fix
                          src/jquery.fancytree.grid.js on lines 942..978

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 46.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          if (ok) {
                                              if (
                                                  flag &&
                                                  ctx.options.autoScroll &&
                                                  !callOpts.noAnimation &&
                          Severity: Minor
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 35 mins to fix
                          src/jquery.fancytree.grid.js on lines 943..969

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 46.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Open

                                          if (node.key && opts.generateIds) {
                                              node.tr.id = opts.idPrefix + node.key;
                                          }
                          Severity: Minor
                          Found in src/jquery.fancytree.grid.js and 2 other locations - About 35 mins to fix
                          src/jquery.fancytree.js on lines 4866..4868
                          src/jquery.fancytree.table.js on lines 313..315

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 46.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if (node.tr) {
                                          delete node.tr.ftnode;
                                          node.tr = null;
                                          node.span = null;
                                      }
                          Severity: Minor
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 35 mins to fix
                          src/jquery.fancytree.grid.js on lines 726..730

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 46.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                          if (n.tr) {
                                              delete n.tr.ftnode;
                                              n.tr = null;
                                              n.span = null;
                                          }
                          Severity: Minor
                          Found in src/jquery.fancytree.grid.js and 1 other location - About 35 mins to fix
                          src/jquery.fancytree.grid.js on lines 736..740

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 46.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status