Sign upLogin

mar10/fancytree

View on GitHub
Star
src/jquery.fancytree.logger.js

Summary

Maintainability
C
1 day
Test Coverage

Function treeCreate has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        treeCreate: function (ctx) {
            var tree = ctx.tree,
                opts = ctx.options;

            if (
Severity: Minor
Found in src/jquery.fancytree.logger.js - About 2 hrs to fix

    Function logHook has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function logHook(name, this_, args, extra) {
        var res,
            ctx = args[0],
            opts = ctx.options.logger,
            obj = ctx.node || ctx.tree,
    Severity: Minor
    Found in src/jquery.fancytree.logger.js - About 1 hr to fix

      Function nodeRender has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              nodeRender: function (ctx, force, deep, collapsed, _recursive) {
      Severity: Minor
      Found in src/jquery.fancytree.logger.js - About 35 mins to fix

        Similar blocks of code found in 16 locations. Consider refactoring.
        Open

        (function (factory) {
    if (typeof define === "function" && define.amd) {
        // AMD. Register as an anonymous module.
        define(["jquery", "./jquery.fancytree"], factory);
    } else if (typeof module === "object" && module.exports) {
        Severity: Major
        Found in src/jquery.fancytree.logger.js and 15 other locations - About 3 hrs to fix
        src/jquery.fancytree.childcounter.js on lines 31..241
        src/jquery.fancytree.clones.js on lines 16..514
        src/jquery.fancytree.columnview.js on lines 16..205
        src/jquery.fancytree.dnd5.js on lines 29..1157
        src/jquery.fancytree.edit.js on lines 16..403
        src/jquery.fancytree.filter.js on lines 16..549
        src/jquery.fancytree.glyph.js on lines 16..354
        src/jquery.fancytree.grid.js on lines 16..1014
        src/jquery.fancytree.js on lines 18..7378
        src/jquery.fancytree.menu.js on lines 18..185
        src/jquery.fancytree.multi.js on lines 16..128
        src/jquery.fancytree.persist.js on lines 18..513
        src/jquery.fancytree.table.js on lines 16..545
        src/jquery.fancytree.themeroller.js on lines 18..125
        src/jquery.fancytree.wide.js on lines 15..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (
            !opts.traceEvents ||
            (opts.traceEvents !== true && $.inArray(name, opts.traceEvents) < 0)
        ) {
            return self._super.apply(self, arguments);
        Severity: Major
        Found in src/jquery.fancytree.logger.js and 1 other location - About 1 hr to fix
        src/jquery.fancytree.logger.js on lines 115..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (
            !opts.traceHooks ||
            (opts.traceHooks !== true && $.inArray(name, opts.traceHooks) < 0)
        ) {
            return this_._superApply.call(this_, args);
        Severity: Major
        Found in src/jquery.fancytree.logger.js and 1 other location - About 1 hr to fix
        src/jquery.fancytree.logger.js on lines 85..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (
            opts.timings === true ||
            (opts.timings && $.inArray(name, opts.timings) >= 0)
        ) {
            // if( name === "nodeRender" ) { logName += obj; }  // allow timing for recursive calls
        Severity: Major
        Found in src/jquery.fancytree.logger.js and 1 other location - About 1 hr to fix
        src/jquery.fancytree.logger.js on lines 91..104

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (
            (self._super && opts.timings === true) ||
            (opts.timings && $.inArray(name, opts.timings) >= 0)
        ) {
            // if( name === "nodeRender" ) { logName += obj; }  // allow timing for recursive calls
        Severity: Major
        Found in src/jquery.fancytree.logger.js and 1 other location - About 1 hr to fix
        src/jquery.fancytree.logger.js on lines 121..139

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status