Sign upLogin

mar10/fancytree

View on GitHub
Star
src/jquery.fancytree.persist.js

Summary

Maintainability
F
4 days
Test Coverage

File jquery.fancytree.persist.js has 398 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*!
 * jquery.fancytree.persist.js
 *
 * Persist tree status in cookiesRemove or highlight tree nodes, based on a filter.
 * (Extension module for jquery.fancytree.js: https://github.com/mar10/fancytree/)
Severity: Minor
Found in src/jquery.fancytree.persist.js - About 5 hrs to fix

    Function treeInit has 122 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            treeInit: function (ctx) {
            var tree = ctx.tree,
                opts = ctx.options,
                local = this._local,
                instOpts = this.options.persist;
    Severity: Major
    Found in src/jquery.fancytree.persist.js - About 4 hrs to fix

      Function _loadLazyNodes has 58 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function _loadLazyNodes(tree, local, keyList, mode, dfd) {
        var i,
            key,
            l,
            node,
      Severity: Major
      Found in src/jquery.fancytree.persist.js - About 2 hrs to fix

        Avoid deeply nested control flow statements.
        Open

                                            if (
                                        node.selected === undefined ||
                                        (instOpts.overrideSource &&
                                            node.selected === false)
                                    ) {
        Severity: Major
        Found in src/jquery.fancytree.persist.js - About 45 mins to fix

          Function _loadLazyNodes has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              function _loadLazyNodes(tree, local, keyList, mode, dfd) {
          Severity: Minor
          Found in src/jquery.fancytree.persist.js - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                try {
        _assert(window.localStorage && window.localStorage.getItem);
        localStorageStore = {
            get: function (key) {
                return window.localStorage.getItem(key);
            Severity: Major
            Found in src/jquery.fancytree.persist.js and 1 other location - About 4 hrs to fix
            src/jquery.fancytree.persist.js on lines 64..79

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                try {
        _assert(window.sessionStorage && window.sessionStorage.getItem);
        sessionStorageStore = {
            get: function (key) {
                return window.sessionStorage.getItem(key);
            Severity: Major
            Found in src/jquery.fancytree.persist.js and 1 other location - About 4 hrs to fix
            src/jquery.fancytree.persist.js on lines 47..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 115.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 16 locations. Consider refactoring.
            Open

            (function (factory) {
    if (typeof define === "function" && define.amd) {
        // AMD. Register as an anonymous module.
        define(["jquery", "./jquery.fancytree"], factory);
    } else if (typeof module === "object" && module.exports) {
            Severity: Major
            Found in src/jquery.fancytree.persist.js and 15 other locations - About 3 hrs to fix
            src/jquery.fancytree.childcounter.js on lines 31..241
            src/jquery.fancytree.clones.js on lines 16..514
            src/jquery.fancytree.columnview.js on lines 16..205
            src/jquery.fancytree.dnd5.js on lines 29..1157
            src/jquery.fancytree.edit.js on lines 16..403
            src/jquery.fancytree.filter.js on lines 16..549
            src/jquery.fancytree.glyph.js on lines 16..354
            src/jquery.fancytree.grid.js on lines 16..1014
            src/jquery.fancytree.js on lines 18..7378
            src/jquery.fancytree.logger.js on lines 16..309
            src/jquery.fancytree.menu.js on lines 18..185
            src/jquery.fancytree.multi.js on lines 16..128
            src/jquery.fancytree.table.js on lines 16..545
            src/jquery.fancytree.themeroller.js on lines 18..125
            src/jquery.fancytree.wide.js on lines 15..257

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 105.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    nodeSetActive: function (ctx, flag, callOpts) {
            var res,
                local = this._local;

            flag = flag !== false;
            Severity: Major
            Found in src/jquery.fancytree.persist.js and 1 other location - About 3 hrs to fix
            src/jquery.fancytree.persist.js on lines 466..480

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    nodeSetFocus: function (ctx, flag) {
            var res,
                local = this._local;

            flag = flag !== false;
            Severity: Major
            Found in src/jquery.fancytree.persist.js and 1 other location - About 3 hrs to fix
            src/jquery.fancytree.persist.js on lines 438..452

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 96.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else if ($ && typeof $.cookie === "function") {
        // Fall back to https://github.com/carhartl/jquery-cookie
        cookieStore = {
            get: $.cookie,
            set: function (key, value) {
            Severity: Major
            Found in src/jquery.fancytree.persist.js and 1 other location - About 1 hr to fix
            src/jquery.fancytree.persist.js on lines 81..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (typeof Cookies === "function") {
        // Assume https://github.com/js-cookie/js-cookie
        cookieStore = {
            get: Cookies.get,
            set: function (key, value) {
            Severity: Major
            Found in src/jquery.fancytree.persist.js and 1 other location - About 1 hr to fix
            src/jquery.fancytree.persist.js on lines 90..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status