Sign upLogin

marcelog/PAGI

View on GitHub
Star

Showing 48 of 227 total issues

Function appliesTo has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function appliesTo(Node $node)
    {
        if ($node->wasCancelled()
            && $this->result == self::NODE_RESULT_CANCEL
        ) {
Severity: Minor
Found in src/PAGI/Node/NodeActionCommand.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in src/PAGI/Client/ChannelStatus.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return "max valid input attempts reached";
    Severity: Major
    Found in src/PAGI/Node/Node.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return 'Line is ringing';
      Severity: Major
      Found in src/PAGI/Client/ChannelStatus.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return 'Line is busy';
        Severity: Major
        Found in src/PAGI/Client/ChannelStatus.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return 'Remote end is ringing';
          Severity: Major
          Found in src/PAGI/Client/ChannelStatus.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return 'Line is up';
            Severity: Major
            Found in src/PAGI/Client/ChannelStatus.php - About 30 mins to fix

              Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function __construct(IReadResult $result)
    {
        parent::__construct($result);
        if ($result->hasData()) {
            // check offset
              Severity: Minor
              Found in src/PAGI/Client/Result/PlayResult.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language