Sign upLogin

martinheidegger/flexlock-cb

View on GitHub
Star

Showing 7 of 8 total issues

File test.js has 498 lines of code (exceeds 250 allowed). Consider refactoring.
Confirmed

'use strict'
const test = require('tap').test
const createLockCb = require('./index.js').createLockCb

test('lock(<process>)', () => {
Severity: Minor
Found in test.js - About 7 hrs to fix

    Function createLock has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function createLock (onEveryRelease) {
  const state = {
    released: true,
    destroyed: null
  }
    Severity: Minor
    Found in lib/createLock.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createLockCb has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function createLockCb (onEveryRelease, onSyncError) {
  const lock = createLock(onEveryRelease)
  if (typeof onSyncError !== 'function') {
    onSyncError = throwErr
  }
    Severity: Minor
    Found in createLockCb.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createLockCb has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function createLockCb (onEveryRelease, onSyncError) {
  const lock = createLock(onEveryRelease)
  if (typeof onSyncError !== 'function') {
    onSyncError = throwErr
  }
    Severity: Major
    Found in createLockCb.js - About 2 hrs to fix

      Function createLock has 69 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function createLock (onEveryRelease) {
  const state = {
    released: true,
    destroyed: null
  }
      Severity: Major
      Found in lib/createLock.js - About 2 hrs to fix

        Function createReleaseMgr has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function createReleaseMgr (state, onEveryRelease) {
  let session = null

  function trigger () {
    if (session === null) {
        Severity: Minor
        Found in lib/releaseMgr.js - About 1 hr to fix

          Function flexLock has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const flexLock = function (process, arg1, arg2, arg3) {
    let timeout, onFulfilled, onRejected
    if (typeof arg1 === 'function') {
      onFulfilled = arg1
      if (typeof arg2 === 'function') {
          Severity: Minor
          Found in createLockCb.js - About 1 hr to fix
            Severity
            Category
            Status
            Source
            Language