Sign upLogin

martinmicunda/employee-scheduling-ui

View on GitHub
Star

Showing 438 of 458 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        it('should have result property', () => {
            employeeAdd = new EmployeeAdd($state, $rootScope, EmployeeModel, FormService, fakeModal);

            expect(employeeAdd.result).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/employees/add/add.spec.js and 7 other locations - About 35 mins to fix
src/app/components/modal-document/modal-document.spec.js on lines 332..336
src/app/components/modal-document/modal-document.spec.js on lines 338..342
src/app/components/modal-message/modal-message.spec.js on lines 224..228
src/app/components/modal-message/modal-message.spec.js on lines 230..234
src/app/routes/layout-app/account/account-details/account-details.spec.js on lines 390..394
src/app/routes/layout-app/account/account-details/account-details.spec.js on lines 396..400
src/app/routes/layout-app/employees/add/add.spec.js on lines 112..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

        it('should have result property', () => {
            accountDetails = new AccountDetails(EmployeeModel, SettingModel, Upload, FormService, EmployeeResource);

            expect(accountDetails.result).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/account/account-details/account-details.spec.js and 7 other locations - About 35 mins to fix
src/app/components/modal-document/modal-document.spec.js on lines 332..336
src/app/components/modal-document/modal-document.spec.js on lines 338..342
src/app/components/modal-message/modal-message.spec.js on lines 224..228
src/app/components/modal-message/modal-message.spec.js on lines 230..234
src/app/routes/layout-app/account/account-details/account-details.spec.js on lines 390..394
src/app/routes/layout-app/employees/add/add.spec.js on lines 112..116
src/app/routes/layout-app/employees/add/add.spec.js on lines 118..122

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Inject('$modal', '$anchorScroll')
    //end-non-standard
    static directiveFactory($location, $anchorScroll){
        MmScrollUp.instance = new MmScrollUp($location, $anchorScroll);
        return MmScrollUp.instance;
Severity: Minor
Found in src/app/directives/scroll-up/scroll-up.js and 2 other locations - About 35 mins to fix
src/app/directives/access-level/access-level.js on lines 49..54
src/app/directives/unique-email-validator/unique-email-validator.js on lines 45..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Inject('EmployeeModel', 'EmployeeResource')
    //end-non-standard
    static directiveFactory(EmployeeModel, EmployeeResource){
        MmUniqueEmailValidator.instance = new MmUniqueEmailValidator(EmployeeModel, EmployeeResource);
        return MmUniqueEmailValidator.instance;
Severity: Minor
Found in src/app/directives/unique-email-validator/unique-email-validator.js and 2 other locations - About 35 mins to fix
src/app/directives/access-level/access-level.js on lines 49..54
src/app/directives/scroll-up/scroll-up.js on lines 33..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    updateAccountDetails(updatedResource) {
        return this.http.put(`/${this.route}/${updatedResource.id}/account`, updatedResource);
    }
Severity: Minor
Found in src/app/core/resources/employee/employee.js and 1 other location - About 35 mins to fix
src/app/core/resources/abstract-resource.js on lines 26..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should have result property', () => {
            employeeEdit = new EmployeeEdit($state, fakeModal, EmployeeModel, FormService);

            expect(employeeEdit.result).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/employees/edit/edit.spec.js and 3 other locations - About 35 mins to fix
src/app/routes/layout-app/employees/edit/edit.spec.js on lines 114..118
src/app/routes/layout-auth/login/login.spec.js on lines 206..210
src/app/routes/layout-auth/login/login.spec.js on lines 212..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should have isSubmitting property', () => {
            login = new Login($rootScope, $state, AuthenticationService, FormService);

            expect(login.isSubmitting).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-auth/login/login.spec.js and 3 other locations - About 35 mins to fix
src/app/routes/layout-app/employees/edit/edit.spec.js on lines 114..118
src/app/routes/layout-app/employees/edit/edit.spec.js on lines 120..124
src/app/routes/layout-auth/login/login.spec.js on lines 212..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should have isSubmitting property', () => {
            employeeEdit = new EmployeeEdit($state, fakeModal, EmployeeModel, FormService);

            expect(employeeEdit.isSubmitting).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/employees/edit/edit.spec.js and 3 other locations - About 35 mins to fix
src/app/routes/layout-app/employees/edit/edit.spec.js on lines 120..124
src/app/routes/layout-auth/login/login.spec.js on lines 206..210
src/app/routes/layout-auth/login/login.spec.js on lines 212..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @Inject('ngIfDirective', 'AuthenticationService')
    //end-non-standard
    static directiveFactory(ngIfDirective, AuthenticationService) {
        MmAccessLevel.instance = new MmAccessLevel(ngIfDirective, AuthenticationService);
        return MmAccessLevel.instance;
Severity: Minor
Found in src/app/directives/access-level/access-level.js and 2 other locations - About 35 mins to fix
src/app/directives/scroll-up/scroll-up.js on lines 33..38
src/app/directives/unique-email-validator/unique-email-validator.js on lines 45..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    update(updatedResource) {
        return this.http.put(`/${this.route}/${updatedResource.id}`, updatedResource);
    }
Severity: Minor
Found in src/app/core/resources/abstract-resource.js and 1 other location - About 35 mins to fix
src/app/core/resources/employee/employee.js on lines 31..33

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        it('should have result property', () => {
            login = new Login($rootScope, $state, AuthenticationService, FormService);

            expect(login.result).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-auth/login/login.spec.js and 3 other locations - About 35 mins to fix
src/app/routes/layout-app/employees/edit/edit.spec.js on lines 114..118
src/app/routes/layout-app/employees/edit/edit.spec.js on lines 120..124
src/app/routes/layout-auth/login/login.spec.js on lines 206..210

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

        it('should have result property', () => {
            contactDetails = new ContactDetails(EmployeeModel, FormService, EmployeeResource);

            expect(contactDetails.result).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/account/contact-details/contact-details.spec.js and 14 other locations - About 30 mins to fix
src/app/components/modal-location/modal-location.spec.js on lines 322..326
src/app/components/modal-location/modal-location.spec.js on lines 328..332
src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
src/app/components/modal-position/modal-position.spec.js on lines 194..198
src/app/components/modal-position/modal-position.spec.js on lines 200..204
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
src/app/routes/layout-app/account/password/password.spec.js on lines 260..264
src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

        it('should have isSubmitting property', () => {
            locationModal = new LocationModal(ModalModel, LocationModel, FormService);

            expect(locationModal.isSubmitting).toEqual(null);
        });
Severity: Major
Found in src/app/components/modal-location/modal-location.spec.js and 14 other locations - About 30 mins to fix
src/app/components/modal-location/modal-location.spec.js on lines 328..332
src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
src/app/components/modal-position/modal-position.spec.js on lines 194..198
src/app/components/modal-position/modal-position.spec.js on lines 200..204
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
src/app/routes/layout-app/account/password/password.spec.js on lines 260..264
src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@RouteConfig('app.employees.add.hourly-rate', {
    url: '/hourly-rate',
    views: {
        'modal@': {
            template: '<employee-hourly-rate></employee-hourly-rate>'
Severity: Major
Found in src/app/routes/layout-app/employees/add/hourly-rate/hourly-rate.js and 7 other locations - About 30 mins to fix
src/app/routes/layout-app/employees/add/account-details/account-details.js on lines 11..20
src/app/routes/layout-app/employees/add/bank-details/bank-details.js on lines 11..20
src/app/routes/layout-app/employees/add/contact-details/contact-details.js on lines 11..20
src/app/routes/layout-app/employees/edit/account-details/account-details.js on lines 11..20
src/app/routes/layout-app/employees/edit/bank-details/bank-details.js on lines 11..20
src/app/routes/layout-app/employees/edit/contact-details/contact-details.js on lines 11..20
src/app/routes/layout-app/employees/edit/hourly-rate/hourly-rate.js on lines 11..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@RouteConfig('app.employees.add.bank-details', {
    url: '/bank-details',
    views: {
        'modal@': {
            template: '<employee-bank-details></employee-bank-details>'
Severity: Major
Found in src/app/routes/layout-app/employees/add/bank-details/bank-details.js and 7 other locations - About 30 mins to fix
src/app/routes/layout-app/employees/add/account-details/account-details.js on lines 11..20
src/app/routes/layout-app/employees/add/contact-details/contact-details.js on lines 11..20
src/app/routes/layout-app/employees/add/hourly-rate/hourly-rate.js on lines 11..20
src/app/routes/layout-app/employees/edit/account-details/account-details.js on lines 11..20
src/app/routes/layout-app/employees/edit/bank-details/bank-details.js on lines 11..20
src/app/routes/layout-app/employees/edit/contact-details/contact-details.js on lines 11..20
src/app/routes/layout-app/employees/edit/hourly-rate/hourly-rate.js on lines 11..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

        it('should have isSubmitting property', () => {
            positionModal = new PositionModal(ModalModel, PositionModel, FormService);

            expect(positionModal.isSubmitting).toEqual(null);
        });
Severity: Major
Found in src/app/components/modal-position/modal-position.spec.js and 14 other locations - About 30 mins to fix
src/app/components/modal-location/modal-location.spec.js on lines 322..326
src/app/components/modal-location/modal-location.spec.js on lines 328..332
src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
src/app/components/modal-position/modal-position.spec.js on lines 200..204
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
src/app/routes/layout-app/account/password/password.spec.js on lines 260..264
src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

        it('should have result property', () => {
            locationModal = new LocationModal(ModalModel, LocationModel, FormService);

            expect(locationModal.result).toEqual(null);
        });
Severity: Major
Found in src/app/components/modal-location/modal-location.spec.js and 14 other locations - About 30 mins to fix
src/app/components/modal-location/modal-location.spec.js on lines 322..326
src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
src/app/components/modal-position/modal-position.spec.js on lines 194..198
src/app/components/modal-position/modal-position.spec.js on lines 200..204
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
src/app/routes/layout-app/account/password/password.spec.js on lines 260..264
src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    getSaveButtonOptions() {
        this.saveButtonOptions.animationCompleteTime = '1200';
        this.saveButtonOptions.buttonErrorClass = 'btn-danger';

        return this.saveButtonOptions;
Severity: Minor
Found in src/app/core/services/form.js and 1 other location - About 30 mins to fix
src/app/core/services/form.js on lines 27..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                return formService.delete(model, item, self).then(() => {
                    expect(self.result).toEqual('success');
                    expect(model.delete).toHaveBeenCalledWith(item);
                });
Severity: Minor
Found in src/app/core/services/form.spec.js and 1 other location - About 30 mins to fix
src/app/core/services/form.spec.js on lines 172..175

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

        it('should have isSubmitting property', () => {
            password = new Password(EmployeeModel, FormService, AuthenticationResource);

            expect(password.isSubmitting).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/account/password/password.spec.js and 14 other locations - About 30 mins to fix
src/app/components/modal-location/modal-location.spec.js on lines 322..326
src/app/components/modal-location/modal-location.spec.js on lines 328..332
src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
src/app/components/modal-position/modal-position.spec.js on lines 194..198
src/app/components/modal-position/modal-position.spec.js on lines 200..204
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language