martinmicunda/employee-scheduling-ui

View on GitHub
src/app/routes/layout-app/account/password/password.spec.js

Summary

Maintainability
F
5 days
Test Coverage

File password.spec.js has 262 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @author    Martin Micunda {@link http://martinmicunda.com}
 * @copyright Copyright (c) 2015, Martin Micunda
 * @license   GPL-3.0
 */
Severity: Minor
Found in src/app/routes/layout-app/account/password/password.spec.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                describe('currentPassword', () => {
                    it('should have `Current Password` label defined', () => {
                        element = render();
                        const parentElement = angular.element(element[0].querySelector('input[name="currentPassword"][type="password"]')).parent().parent();
    
    
    Severity: Major
    Found in src/app/routes/layout-app/account/password/password.spec.js and 1 other location - About 2 days to fix
    src/app/components/modal-position/modal-position.spec.js on lines 132..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 394.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        describe('Route', () => {
            let url = '/account/password',
                state = 'app.account.password',
                currentState,
                $state, $injector;
    Severity: Major
    Found in src/app/routes/layout-app/account/password/password.spec.js and 4 other locations - About 6 hrs to fix
    src/app/routes/layout-app/account/account-details/account-details.spec.js on lines 16..36
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 16..36
    src/app/routes/layout-auth/forgot-password/forgot-password.spec.js on lines 16..36
    src/app/routes/layout-auth/login/login.spec.js on lines 16..36

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 158.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 10 locations. Consider refactoring.
    Open

            it('should have `jp-ng-bs-animated-button` component defined with attributes `is-submitting`, `result` and `options`', () => {
                element = render();
                const saveButton = angular.element(element[0].querySelector('button.btn-success'));
    
                expect(saveButton[0]).toBeDefined();
    Severity: Major
    Found in src/app/routes/layout-app/account/password/password.spec.js and 9 other locations - About 5 hrs to fix
    src/app/components/modal-document/modal-document.spec.js on lines 123..131
    src/app/components/modal-location/modal-location.spec.js on lines 130..138
    src/app/components/modal-message/modal-message.spec.js on lines 120..128
    src/app/components/modal-partner/modal-partner.spec.js on lines 152..160
    src/app/components/modal-position/modal-position.spec.js on lines 120..128
    src/app/routes/layout-app/account/account-details/account-details.spec.js on lines 349..357
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 206..214
    src/app/routes/layout-auth/forgot-password/forgot-password.spec.js on lines 95..103
    src/app/routes/layout-auth/login/login.spec.js on lines 92..100

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 137.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            it('should not save if form is invalid', () => {
                let form = {$valid: false};
                spyOn(FormService, 'save');
                password = new Password(EmployeeModel, FormService, AuthenticationResource);
    
    
    Severity: Major
    Found in src/app/routes/layout-app/account/password/password.spec.js and 5 other locations - About 3 hrs to fix
    src/app/components/modal-location/modal-location.spec.js on lines 353..362
    src/app/components/modal-partner/modal-partner.spec.js on lines 464..473
    src/app/components/modal-position/modal-position.spec.js on lines 224..233
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 261..270
    src/app/routes/layout-app/settings/language/language.spec.js on lines 119..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 20 locations. Consider refactoring.
    Open

            it('should have saveButtonOptions property', () => {
                spyOn(FormService, 'getModalSaveButtonOptions').and.returnValue(itemMock);
                password = new Password(EmployeeModel, FormService, AuthenticationResource);
    
                expect(password.saveButtonOptions).toEqual(itemMock);
    src/app/components/modal-location/modal-location.spec.js on lines 257..263
    src/app/components/modal-location/modal-location.spec.js on lines 334..340
    src/app/components/modal-partner/modal-partner.spec.js on lines 402..408
    src/app/components/modal-partner/modal-partner.spec.js on lines 446..452
    src/app/components/modal-position/modal-position.spec.js on lines 178..184
    src/app/components/modal-position/modal-position.spec.js on lines 186..192
    src/app/components/modal-position/modal-position.spec.js on lines 206..212
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 226..232
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 246..252
    src/app/routes/layout-app/account/password/password.spec.js on lines 252..258
    src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 147..153
    src/app/routes/layout-app/employees/employees.spec.js on lines 88..94
    src/app/routes/layout-app/employees/employees.spec.js on lines 96..102
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 94..100
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 102..108
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 122..128
    src/app/routes/layout-app/settings/language/language.spec.js on lines 83..89
    src/app/routes/layout-app/settings/language/language.spec.js on lines 91..97
    src/app/routes/layout-app/settings/language/language.spec.js on lines 111..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 20 locations. Consider refactoring.
    Open

            it('should have employee property', () => {
                spyOn(EmployeeModel, 'getItem').and.returnValue(itemMock);
                password = new Password(EmployeeModel, FormService, AuthenticationResource);
    
                expect(password.employee).toEqual(itemMock);
    src/app/components/modal-location/modal-location.spec.js on lines 257..263
    src/app/components/modal-location/modal-location.spec.js on lines 334..340
    src/app/components/modal-partner/modal-partner.spec.js on lines 402..408
    src/app/components/modal-partner/modal-partner.spec.js on lines 446..452
    src/app/components/modal-position/modal-position.spec.js on lines 178..184
    src/app/components/modal-position/modal-position.spec.js on lines 186..192
    src/app/components/modal-position/modal-position.spec.js on lines 206..212
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 226..232
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 246..252
    src/app/routes/layout-app/account/password/password.spec.js on lines 272..278
    src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 147..153
    src/app/routes/layout-app/employees/employees.spec.js on lines 88..94
    src/app/routes/layout-app/employees/employees.spec.js on lines 96..102
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 94..100
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 102..108
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 122..128
    src/app/routes/layout-app/settings/language/language.spec.js on lines 83..89
    src/app/routes/layout-app/settings/language/language.spec.js on lines 91..97
    src/app/routes/layout-app/settings/language/language.spec.js on lines 111..117

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

            it('should have `Password` title defined', () => {
                element = render();
                const title = element.find('h4');
    
                expect(title.text()).toEqual('Password');
    src/app/components/employee-account-details/employee-account-details.spec.js on lines 58..63
    src/app/components/employee-bank-details/employee-bank-details.spec.js on lines 43..48
    src/app/components/employee-contact-details/employee-contact-details.spec.js on lines 43..48
    src/app/components/employee-hourly-rate/employee-hourly-rate.spec.js on lines 44..49
    src/app/routes/layout-app/account/account-details/account-details.spec.js on lines 65..70
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 62..67
    src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 67..72
    src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 74..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it('should calculate profile completeness when controller is loaded', () => {
                spyOn(EmployeeModel, 'calculateProfileCompleteness');
                password = new Password(EmployeeModel, FormService, AuthenticationResource);
    
                expect(EmployeeModel.calculateProfileCompleteness).toHaveBeenCalled();
    Severity: Minor
    Found in src/app/routes/layout-app/account/password/password.spec.js and 1 other location - About 50 mins to fix
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 254..259

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

            it('should have isSubmitting property', () => {
                password = new Password(EmployeeModel, FormService, AuthenticationResource);
    
                expect(password.isSubmitting).toEqual(null);
            });
    Severity: Major
    Found in src/app/routes/layout-app/account/password/password.spec.js and 14 other locations - About 30 mins to fix
    src/app/components/modal-location/modal-location.spec.js on lines 322..326
    src/app/components/modal-location/modal-location.spec.js on lines 328..332
    src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
    src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
    src/app/components/modal-position/modal-position.spec.js on lines 194..198
    src/app/components/modal-position/modal-position.spec.js on lines 200..204
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
    src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
    src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
    src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
    src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 15 locations. Consider refactoring.
    Open

            it('should have result property', () => {
                password = new Password(EmployeeModel, FormService, AuthenticationResource);
    
                expect(password.result).toEqual(null);
            });
    Severity: Major
    Found in src/app/routes/layout-app/account/password/password.spec.js and 14 other locations - About 30 mins to fix
    src/app/components/modal-location/modal-location.spec.js on lines 322..326
    src/app/components/modal-location/modal-location.spec.js on lines 328..332
    src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
    src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
    src/app/components/modal-position/modal-position.spec.js on lines 194..198
    src/app/components/modal-position/modal-position.spec.js on lines 200..204
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
    src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
    src/app/routes/layout-app/account/password/password.spec.js on lines 260..264
    src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
    src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
    src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
    src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status