Sign upLogin

martinmicunda/employee-scheduling-ui

View on GitHub
Star
src/app/routes/layout-app/settings/currency/currency.spec.js

Summary

Maintainability
D
2 days
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    describe('Route', () => {
        let url = '/settings/currency',
            state = 'app.settings.currency',
            currentState,
            $state, $injector, SettingModel, CurrencyModel;
Severity: Major
Found in src/app/routes/layout-app/settings/currency/currency.spec.js and 1 other location - About 1 day to fix
src/app/routes/layout-app/settings/language/language.spec.js on lines 15..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 287.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

        it('should have currencies property', () => {
            spyOn(CurrencyModel, 'getCollection').and.returnValue(currencies);
            currency = new Currency(SettingModel, CurrencyModel, FormService);

            expect(currency.currencies).toEqual(currencies);
Severity: Major
Found in src/app/routes/layout-app/settings/currency/currency.spec.js and 19 other locations - About 2 hrs to fix
src/app/components/modal-location/modal-location.spec.js on lines 257..263
src/app/components/modal-location/modal-location.spec.js on lines 334..340
src/app/components/modal-partner/modal-partner.spec.js on lines 402..408
src/app/components/modal-partner/modal-partner.spec.js on lines 446..452
src/app/components/modal-position/modal-position.spec.js on lines 178..184
src/app/components/modal-position/modal-position.spec.js on lines 186..192
src/app/components/modal-position/modal-position.spec.js on lines 206..212
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 226..232
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 246..252
src/app/routes/layout-app/account/password/password.spec.js on lines 252..258
src/app/routes/layout-app/account/password/password.spec.js on lines 272..278
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 147..153
src/app/routes/layout-app/employees/employees.spec.js on lines 88..94
src/app/routes/layout-app/employees/employees.spec.js on lines 96..102
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 94..100
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 122..128
src/app/routes/layout-app/settings/language/language.spec.js on lines 83..89
src/app/routes/layout-app/settings/language/language.spec.js on lines 91..97
src/app/routes/layout-app/settings/language/language.spec.js on lines 111..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

        it('should have saveButtonOptions property', () => {
            spyOn(FormService, 'getSaveButtonOptions').and.returnValue(collectionMock);
            currency = new Currency(SettingModel, CurrencyModel, FormService);

            expect(currency.saveButtonOptions).toEqual(collectionMock);
Severity: Major
Found in src/app/routes/layout-app/settings/currency/currency.spec.js and 19 other locations - About 2 hrs to fix
src/app/components/modal-location/modal-location.spec.js on lines 257..263
src/app/components/modal-location/modal-location.spec.js on lines 334..340
src/app/components/modal-partner/modal-partner.spec.js on lines 402..408
src/app/components/modal-partner/modal-partner.spec.js on lines 446..452
src/app/components/modal-position/modal-position.spec.js on lines 178..184
src/app/components/modal-position/modal-position.spec.js on lines 186..192
src/app/components/modal-position/modal-position.spec.js on lines 206..212
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 226..232
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 246..252
src/app/routes/layout-app/account/password/password.spec.js on lines 252..258
src/app/routes/layout-app/account/password/password.spec.js on lines 272..278
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 147..153
src/app/routes/layout-app/employees/employees.spec.js on lines 88..94
src/app/routes/layout-app/employees/employees.spec.js on lines 96..102
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 94..100
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 102..108
src/app/routes/layout-app/settings/language/language.spec.js on lines 83..89
src/app/routes/layout-app/settings/language/language.spec.js on lines 91..97
src/app/routes/layout-app/settings/language/language.spec.js on lines 111..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 20 locations. Consider refactoring.
Open

        it('should have setting property', () => {
            spyOn(SettingModel, 'getItem').and.returnValue(collectionMock);
            currency = new Currency(SettingModel, CurrencyModel, FormService);

            expect(currency.setting).toEqual(collectionMock);
Severity: Major
Found in src/app/routes/layout-app/settings/currency/currency.spec.js and 19 other locations - About 2 hrs to fix
src/app/components/modal-location/modal-location.spec.js on lines 257..263
src/app/components/modal-location/modal-location.spec.js on lines 334..340
src/app/components/modal-partner/modal-partner.spec.js on lines 402..408
src/app/components/modal-partner/modal-partner.spec.js on lines 446..452
src/app/components/modal-position/modal-position.spec.js on lines 178..184
src/app/components/modal-position/modal-position.spec.js on lines 186..192
src/app/components/modal-position/modal-position.spec.js on lines 206..212
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 226..232
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 246..252
src/app/routes/layout-app/account/password/password.spec.js on lines 252..258
src/app/routes/layout-app/account/password/password.spec.js on lines 272..278
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 147..153
src/app/routes/layout-app/employees/employees.spec.js on lines 88..94
src/app/routes/layout-app/employees/employees.spec.js on lines 96..102
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 102..108
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 122..128
src/app/routes/layout-app/settings/language/language.spec.js on lines 83..89
src/app/routes/layout-app/settings/language/language.spec.js on lines 91..97
src/app/routes/layout-app/settings/language/language.spec.js on lines 111..117

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 83.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

        it('should have result property', () => {
            currency = new Currency(SettingModel, CurrencyModel, FormService);

            expect(currency.result).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/settings/currency/currency.spec.js and 14 other locations - About 30 mins to fix
src/app/components/modal-location/modal-location.spec.js on lines 322..326
src/app/components/modal-location/modal-location.spec.js on lines 328..332
src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
src/app/components/modal-position/modal-position.spec.js on lines 194..198
src/app/components/modal-position/modal-position.spec.js on lines 200..204
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
src/app/routes/layout-app/account/password/password.spec.js on lines 260..264
src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 110..114
src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

        it('should have isSubmitting property', () => {
            currency = new Currency(SettingModel, CurrencyModel, FormService);

            expect(currency.isSubmitting).toEqual(null);
        });
Severity: Major
Found in src/app/routes/layout-app/settings/currency/currency.spec.js and 14 other locations - About 30 mins to fix
src/app/components/modal-location/modal-location.spec.js on lines 322..326
src/app/components/modal-location/modal-location.spec.js on lines 328..332
src/app/components/modal-partner/modal-partner.spec.js on lines 434..438
src/app/components/modal-partner/modal-partner.spec.js on lines 440..444
src/app/components/modal-position/modal-position.spec.js on lines 194..198
src/app/components/modal-position/modal-position.spec.js on lines 200..204
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 234..238
src/app/routes/layout-app/account/contact-details/contact-details.spec.js on lines 240..244
src/app/routes/layout-app/account/password/password.spec.js on lines 260..264
src/app/routes/layout-app/account/password/password.spec.js on lines 266..270
src/app/routes/layout-app/employees/edit/password/password.spec.js on lines 155..159
src/app/routes/layout-app/settings/currency/currency.spec.js on lines 116..120
src/app/routes/layout-app/settings/language/language.spec.js on lines 99..103
src/app/routes/layout-app/settings/language/language.spec.js on lines 105..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status