marusoft/Auto-Mart

View on GitHub
server/controllers/carControllers.js

Summary

Maintainability
C
1 day
Test Coverage

Function ViewAllUnsoldCars has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  static async ViewAllUnsoldCars(req, res, next) {
    const {

      status, state, manufacturer, body_type,
    } = req.query;
Severity: Major
Found in server/controllers/carControllers.js - About 4 hrs to fix

    Function ViewAllUnsoldCars has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      static async ViewAllUnsoldCars(req, res, next) {
        const {
    
          status, state, manufacturer, body_type,
        } = req.query;
    Severity: Minor
    Found in server/controllers/carControllers.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createCarSaleAD has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      static async createCarSaleAD(req, res) {
        const { id } = req.user;
    
        const sql = `INSERT INTO cars(owner, state, price, manufacturer, model, body_type, img_url)  
                     VALUES($1, $2, $3, $4, $5, $6, $7) RETURNING *`;
    Severity: Minor
    Found in server/controllers/carControllers.js - About 1 hr to fix

      Function ViewASpecificCar has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        static async ViewASpecificCar(req, res) {
          const { id } = req.params;
          const findOneCarSql = 'SELECT * FROM cars WHERE id = $1';
          const value = Number(id);
          try {
      Severity: Minor
      Found in server/controllers/carControllers.js - About 1 hr to fix

        Function updateCarPrice has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          static async updateCarPrice(req, res) {
            const { id } = req.params;
            const val = Number(id);
            const { price } = req.body;
            const findACar = 'SELECT * FROM cars WHERE id = $1';
        Severity: Minor
        Found in server/controllers/carControllers.js - About 1 hr to fix

          Function updateCarPrice has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            static async updateCarPrice(req, res) {
              const { id } = req.params;
              const val = Number(id);
              const { price } = req.body;
              const findACar = 'SELECT * FROM cars WHERE id = $1';
          Severity: Minor
          Found in server/controllers/carControllers.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status