mattbrictson/bundle_update_interactive

View on GitHub

Showing 7 of 7 total issues

Method traverse_transient_dependencies has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def traverse_transient_dependencies(*gem_names) # rubocop:disable Metrics/AbcSize
      traversal = Set.new
      stack = gem_names.flatten
      until stack.empty?
        specs_by_name[stack.pop].dependencies.each do |dep|
Severity: Minor
Found in lib/bundle_update_interactive/lockfile.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def run(argv: ARGV) # rubocop:disable Metrics/AbcSize
      options = Options.parse(argv)
      report, updater = generate_report(options)

      puts_legend_and_withheld_gems(report) unless report.empty?
Severity: Minor
Found in lib/bundle_update_interactive/cli.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build_parser has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def build_parser(options) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
        OptionParser.new do |parser| # rubocop:disable Metrics/BlockLength
          parser.summary_indent = "  "
          parser.summary_width = 24
          parser.on("--commit", "Create a git commit for each selected gem update") do
Severity: Minor
Found in lib/bundle_update_interactive/cli/options.rb - About 1 hr to fix

    Method build_outdated_gems has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def build_outdated_gems(lockfile_contents)
          updated_lockfile = Lockfile.parse(lockfile_contents)
          current_lockfile.entries.each_with_object({}) do |current_lockfile_entry, hash|
            name = current_lockfile_entry.name
            updated_lockfile_entry = updated_lockfile && updated_lockfile[name]
    Severity: Minor
    Found in lib/bundle_update_interactive/updater.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetch_rubygems_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def fetch_rubygems_data(name, version)
          api_url = if version.nil?
                      "https://rubygems.org/api/v1/gems/#{name}.json"
                    else
                      "https://rubygems.org/api/v2/rubygems/#{name}/versions/#{version}.json"
    Severity: Minor
    Found in lib/bundle_update_interactive/changelog_locator.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method changelog_uri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def changelog_uri
          return @changelog_uri if defined?(@changelog_uri)
    
          @changelog_uri =
            if (diff_url = build_git_diff_url)
    Severity: Minor
    Found in lib/bundle_update_interactive/outdated_gem.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_withheld_gems has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def find_withheld_gems(exclude: [])
          possibly_withheld = gemfile.dependencies.filter_map do |dep|
            dep.name if dep.should_include? && !dep.requirement.none? # rubocop:disable Style/InverseMethods
          end
          possibly_withheld -= exclude
    Severity: Minor
    Found in lib/bundle_update_interactive/updater.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language