Sign upLogin

matthooks/vimeo

View on GitHub
Star

Showing 3 of 3 total issues

Method create_api_method has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def create_api_method(method, vimeo_method, options={})
    options = { :required => [], :optional => [] }.merge(options)

    method = method.to_s
    camelized_method = camelize(method, false)
Severity: Minor
Found in lib/vimeo/advanced/base.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def initialize(vimeo, oauth_consumer, io, size, filename)
Severity: Minor
Found in lib/vimeo/advanced/simple_upload/task.rb - About 35 mins to fix

    Method validate_response! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def validate_response!(response)
        raise "empty response" unless response

        status = response["stat"]
        if status and status != "ok"
    Severity: Minor
    Found in lib/vimeo/advanced/base.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language