Showing 4 of 4 total issues
Class Attachment
has 29 methods (exceeds 20 allowed). Consider refactoring. Open
class Attachment < ActiveRecord::Base
self.table_name = 'attachments'
after_destroy :delete_files
Method validate_attachment
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def validate_attachment(record, attachment)
unless attachment.blank?
CHECKS.each do |name, operator|
if options.has_key?(name)
other = options[name]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_attachment
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def validate_attachment(record, attachment)
unless attachment.blank?
if options.has_key?(:is)
if options[:is] != attachment.content_type
attachment.errors.add :content_type, :allowed_list, list: options[:is]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method upload
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def upload
if params[:chunk]
@attachment.store(
params[:chunk],
if Rails.env.production?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"