Sign upLogin

matvey-b/project-lvl1-s320

View on GitHub
Star

Showing 6 of 8 total issues

Function gcdBinary has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

export const gcdBinary = (m, n) => {
  if (m === 0) return n;
  if (n === 0) return m;
  if (m === n) return m;
  if (m === 1 || n === 1) return 1;
Severity: Minor
Found in src/games/gcd.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

  return gcdBinary((m - n) / 2, n);
Severity: Major
Found in src/games/gcd.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

      if (n > m) return gcdBinary((n - m) / 2, m);
    Severity: Major
    Found in src/games/gcd.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

        if (isEven(m)) return gcdBinary(m / 2, n);
      Severity: Major
      Found in src/games/gcd.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          if (isEven(n)) return gcdBinary(m, n / 2);
        Severity: Major
        Found in src/games/gcd.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            if (isEven(m) && isEven(n)) return 2 * gcdBinary(m / 2, n / 2);
          Severity: Major
          Found in src/games/gcd.js - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language