maximalink/jquery_sortable_tree

View on GitHub

Showing 3 of 7 total issues

Function _mouseDrag has 89 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        _mouseDrag: function(event) {

            //Compute the helpers position
            this.position = this._generatePosition(event);
            this.positionAbs = this._convertPositionTo("absolute");
Severity: Major
Found in app/assets/javascripts/nested_sortable/jquery.ui.nestedSortable.js - About 3 hrs to fix

    Function toArray has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            toArray: function(o) {
    
                o = o || {};
                var sDepth = o.startDepthCount || 0;
                var ret = [];
    Severity: Minor
    Found in app/assets/javascripts/nested_sortable/jquery.ui.nestedSortable.js - About 1 hr to fix

      Method prev_next_parent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def prev_next_parent
            return 'prev' unless prev_id.zero?
            return 'next' unless next_id.zero?
            return 'parent' unless parent_id.zero?
          end
      Severity: Minor
      Found in app/controllers/jquery_sortable_tree_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language